Skip to content

Upgrade to the latest dev dependency before TypeSpec GA#3135

Merged
MaryGao merged 32 commits intoAzure:mainfrom
v-jiaodi:monitor-nightly325
Apr 2, 2025
Merged

Upgrade to the latest dev dependency before TypeSpec GA#3135
MaryGao merged 32 commits intoAzure:mainfrom
v-jiaodi:monitor-nightly325

Conversation

@v-jiaodi
Copy link
Copy Markdown
Member

@v-jiaodi v-jiaodi commented Mar 25, 2025

fixes #3145

@v-jiaodi v-jiaodi self-assigned this Mar 25, 2025
@MaryGao MaryGao changed the title Monitor nightly CI Upgrade to the latest dependency in early April Apr 1, 2025
});

it("bytes/bytes[] in general model - should be treated as base64 string", async () => {
it.skip("bytes/bytes[] in general model - should be treated as base64 string", async () => {
Copy link
Copy Markdown
Member

@MaryGao MaryGao Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped failed cases. Issue tracked -#3147

});

it("bytes/bytes[]/union in general model- should be treated as base64 string", async () => {
it.skip("bytes/bytes[]/union in general model- should be treated as base64 string", async () => {
Copy link
Copy Markdown
Member

@MaryGao MaryGao Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped failed cases. #3147

updateRun: (threadId: string, runId: string, options?: AgentsUpdateRunOptionalParams) => Promise<ThreadRun>;
updateThread: (threadId: string, options?: AgentsUpdateThreadOptionalParams) => Promise<AgentThread>;
uploadFile: (file: Uint8Array, purpose: FilePurpose, options?: AgentsUploadFileOptionalParams) => Promise<OpenAIFile>;
uploadFile: (body: {
Copy link
Copy Markdown
Member

@MaryGao MaryGao Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


export declare interface FormDataOperations {
anonymousModel: (profileImage: Uint8Array, options?: FormDataAnonymousModelOptionalParams) => Promise<void>;
anonymousModel: (body: {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Not supported yet
// One column is removed in old version but added in latest version
// The only way is to cast to any
it.skip("versioning removed test modelV33_V2preview", async () => {
Copy link
Copy Markdown
Member

@MaryGao MaryGao Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped this case because we don't support this formally. We couldn't bypass this because spector has more strict check: microsoft/typespec#6565.

// Not supported yet
// One column is removed in old version but added in latest version
// The only way is to cast to any
it.skip("versioning removed test modelV33_V2preview", async () => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped this case due to we don't support this formally. We couldn't bypass this because spector has more strict check: microsoft/typespec#6565.

// Not supported yet
// One column is removed in old version but added in latest version
// The only way is to cast to any
it.skip("versioning removed test modelV33_V2preview", async () => {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped this case due to we don't support this formally. We couldn't bypass this because spector has more strict check: microsoft/typespec#6565.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-jiaodi Could you have another pr to re-write this case? We need to build different vesion for different api-version not the same version to share them.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue tracked: #3149

Comment thread packages/typespec-test/package.json Outdated
{
subscriptionId: context.subscriptionId,
"api-version": context.apiVersion,
"api%2Dversion": context.apiVersion,
Copy link
Copy Markdown
Member

@MaryGao MaryGao Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted change: #3145 and I verify api-version should work for mgmt SDK.

@MaryGao MaryGao marked this pull request as ready for review April 1, 2025 14:35
@MaryGao MaryGao requested a review from joheredi as a code owner April 1, 2025 14:35

import { NetworkAnalyticsApiContext as Client } from "../index.js";
import {
errorResponseDeserializer,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiaozha Could we fix the import order? It seems the order is unstable and we need to regen serveral times to match with sequence in ci, the most bad case is we can't produce same order with ci verison.

@MaryGao MaryGao changed the title Upgrade to the latest dependency in early April Upgrade to the latest dev dependency before TypeSpec GA Apr 2, 2025
@MaryGao
Copy link
Copy Markdown
Member

MaryGao commented Apr 2, 2025

Merge this and if anything incorrect let us fix this in following pr. /@qiaozha

@MaryGao MaryGao merged commit b9bc315 into Azure:main Apr 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accepted change] Encode hyphen - to %2D for any query parameter name

3 participants