Skip to content

Add case for azure arm operation templates #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaryGao merged 12 commits into from
Jul 1, 2025
Merged

Add case for azure arm operation templates #3337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e11a31b
add case for azure arm operation templates
v-jiaodi Jun 27, 2025
15abd98
format
v-jiaodi Jun 27, 2025
1c7ccf1
update
v-jiaodi Jun 30, 2025
06e18a2
add rlc case
v-jiaodi Jun 30, 2025
579876b
update case
v-jiaodi Jun 30, 2025
be36127
Merge branch 'main' of https://github.com/Azure/autorest.typescript i…
v-jiaodi Jun 30, 2025
f7b9bd1
update case
v-jiaodi Jun 30, 2025
a95135d
fix lro response
v-jiaodi Jul 1, 2025
c0bd80e
regen code
v-jiaodi Jul 1, 2025
bb1a6ae
Merge branch 'main' of https://github.com/Azure/autorest.typescript i…
v-jiaodi Jul 1, 2025
be30c4c
update code
v-jiaodi Jul 1, 2025
455e98b
Merge branch 'main' into add-case-operation-templates
MaryGao Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions ...ics.Management/generated/typespec-ts/sdk/test/arm-test/src/api/dataProducts/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ export function _createSend(
export async function _createDeserialize(
result: PathUncheckedResponse,
): Promise<DataProduct> {
const expectedStatuses = ["200", "201"];
const expectedStatuses = ["200", "201", "202"];
if (!expectedStatuses.includes(result.status)) {
const error = createRestError(result);
error.details = errorResponseDeserializer(result.body);
Expand All @@ -738,17 +738,22 @@ export function create(
resource: DataProduct,
options: DataProductsCreateOptionalParams = { requestOptions: {} },
): PollerLike<OperationState<DataProduct>, DataProduct> {
return getLongRunningPoller(context, _createDeserialize, ["200", "201"], {
updateIntervalInMs: options?.updateIntervalInMs,
abortSignal: options?.abortSignal,
getInitialResponse: () =>
_createSend(
context,
resourceGroupName,
dataProductName,
resource,
options,
),
resourceLocationConfig: "azure-async-operation",
}) as PollerLike<OperationState<DataProduct>, DataProduct>;
return getLongRunningPoller(
context,
_createDeserialize,
["200", "201", "202"],
{
updateIntervalInMs: options?.updateIntervalInMs,
abortSignal: options?.abortSignal,
getInitialResponse: () =>
_createSend(
context,
resourceGroupName,
dataProductName,
resource,
options,
),
resourceLocationConfig: "azure-async-operation",
},
) as PollerLike<OperationState<DataProduct>, DataProduct>;
}
35 changes: 20 additions & 15 deletions ...lytics.Management/generated/typespec-ts/sdk/test/arm-test/src/api/dataTypes/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ export function _createSend(
export async function _createDeserialize(
result: PathUncheckedResponse,
): Promise<DataType> {
const expectedStatuses = ["200", "201"];
const expectedStatuses = ["200", "201", "202"];
if (!expectedStatuses.includes(result.status)) {
const error = createRestError(result);
error.details = errorResponseDeserializer(result.body);
Expand All @@ -519,18 +519,23 @@ export function create(
resource: DataType,
options: DataTypesCreateOptionalParams = { requestOptions: {} },
): PollerLike<OperationState<DataType>, DataType> {
return getLongRunningPoller(context, _createDeserialize, ["200", "201"], {
updateIntervalInMs: options?.updateIntervalInMs,
abortSignal: options?.abortSignal,
getInitialResponse: () =>
_createSend(
context,
resourceGroupName,
dataProductName,
dataTypeName,
resource,
options,
),
resourceLocationConfig: "azure-async-operation",
}) as PollerLike<OperationState<DataType>, DataType>;
return getLongRunningPoller(
context,
_createDeserialize,
["200", "201", "202"],
{
updateIntervalInMs: options?.updateIntervalInMs,
abortSignal: options?.abortSignal,
getInitialResponse: () =>
_createSend(
context,
resourceGroupName,
dataProductName,
dataTypeName,
resource,
options,
),
resourceLocationConfig: "azure-async-operation",
},
) as PollerLike<OperationState<DataType>, DataType>;
}
7 changes: 5 additions & 2 deletions ...kAnalytics.Management/generated/typespec-ts/sdk/test/arm-test/src/restorePollerHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,10 @@ const deserializeMap: Record<string, DeserializationHelper> = {
"PATCH /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetworkAnalytics/dataProducts/{dataProductName}":
{ deserializer: _updateDeserialize, expectedStatuses: ["200", "202"] },
"PUT /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetworkAnalytics/dataProducts/{dataProductName}":
{ deserializer: _createDeserialize, expectedStatuses: ["200", "201"] },
{
deserializer: _createDeserialize,
expectedStatuses: ["200", "201", "202"],
},
"POST /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetworkAnalytics/dataProducts/{dataProductName}/dataTypes/{dataTypeName}/deleteData":
{
deserializer: _deleteDataDeserialize,
Expand All @@ -118,7 +121,7 @@ const deserializeMap: Record<string, DeserializationHelper> = {
"PUT /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.NetworkAnalytics/dataProducts/{dataProductName}/dataTypes/{dataTypeName}":
{
deserializer: _createDeserializeDataTypes,
expectedStatuses: ["200", "201"],
expectedStatuses: ["200", "201", "202"],
},
};

Expand Down
4 changes: 2 additions & 2 deletions packages/typespec-test/test/widget_dpg/generated/typespec-ts/src/api/budgets/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ export function _createOrReplaceSend(
export async function _createOrReplaceDeserialize(
result: PathUncheckedResponse,
): Promise<SAPUser> {
const expectedStatuses = ["201", "200"];
const expectedStatuses = ["201", "200", "202"];
if (!expectedStatuses.includes(result.status)) {
throw createRestError(result);
}
Expand All @@ -157,7 +157,7 @@ export function createOrReplace(
return getLongRunningPoller(
context,
_createOrReplaceDeserialize,
["201", "200"],
["201", "200", "202"],
{
updateIntervalInMs: options?.updateIntervalInMs,
abortSignal: options?.abortSignal,
Expand Down
4 changes: 2 additions & 2 deletions ...ages/typespec-test/test/widget_dpg/generated/typespec-ts/src/api/sapWidgets/operations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export function _createOrReplaceSend(
export async function _createOrReplaceDeserialize(
result: PathUncheckedResponse,
): Promise<SAPUser> {
const expectedStatuses = ["201", "200"];
const expectedStatuses = ["201", "200", "202"];
if (!expectedStatuses.includes(result.status)) {
throw createRestError(result);
}
Expand All @@ -244,7 +244,7 @@ export function createOrReplace(
return getLongRunningPoller(
context,
_createOrReplaceDeserialize,
["201", "200"],
["201", "200", "202"],
{
updateIntervalInMs: options?.updateIntervalInMs,
abortSignal: options?.abortSignal,
Expand Down
4 changes: 2 additions & 2 deletions packages/typespec-test/test/widget_dpg/generated/typespec-ts/src/restorePollerHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ interface DeserializationHelper {
const deserializeMap: Record<string, DeserializationHelper> = {
"PUT /budgets/widgets/createOrReplace/users/{name}": {
deserializer: _createOrReplaceDeserialize,
expectedStatuses: ["201", "200"],
expectedStatuses: ["201", "200", "202"],
},
"PUT /widgets/widgets/createOrReplace/users/{name}": {
deserializer: _createOrReplaceDeserializeSapWidgets,
expectedStatuses: ["201", "200"],
expectedStatuses: ["201", "200", "202"],
},
};

Expand Down
10 changes: 3 additions & 7 deletions packages/typespec-ts/src/modular/helpers/operationHelpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1550,14 +1550,10 @@ export function getPropertyFullName(
* @param operation The operation
*/
export function getExpectedStatuses(operation: ServiceOperation): string {
const statusCodes = operation.operation.responses.map((x) => x.statusCodes);
let statusCodes = operation.operation.responses.map((x) => x.statusCodes);
// LROs may call the same path but with GET to get the operation status.
if (
isLroOnlyOperation(operation) &&
operation.operation.verb !== "get" &&
!statusCodes.includes(200)
) {
statusCodes.push(200);
if (isLroOnlyOperation(operation) && operation.operation.verb !== "get") {
statusCodes = Array.from(new Set([...statusCodes, 200, 202]));
}

return `[${statusCodes.map((x) => `"${x}"`).join(", ")}]`;
Expand Down
Loading
Loading
⚡