Skip to content

Pnpm migration#3366

Merged
MaryGao merged 37 commits intoAzure:mainfrom
jeremymeng:pnpm-migration
Dec 2, 2025
Merged

Pnpm migration#3366
MaryGao merged 37 commits intoAzure:mainfrom
jeremymeng:pnpm-migration

Conversation

@jeremymeng
Copy link
Copy Markdown
Member

No description provided.

@jeremymeng jeremymeng marked this pull request as draft July 7, 2025 22:01
@jeremymeng
Copy link
Copy Markdown
Member Author

Here's what it looks like for migrating to pnpm

@qiaozha
Copy link
Copy Markdown
Member

qiaozha commented Jul 9, 2025

@jeremymeng could you update the ci.yaml/release.yaml? I think those have references to the rush scripts.

@jeremymeng
Copy link
Copy Markdown
Member Author

@jeremymeng could you update the ci.yaml/release.yaml? I think those have references to the rush scripts.

@qiaozha I have updated files under .scripts and no longer see any references of "rush". I don't know for sure though whether replacing them with pnpm works as expected.

Comment thread packages/typespec-ts/test/integration/multipart.spec.ts Outdated
Comment thread packages/autorest.typescript/test/rlcIntegration/lroRest.spec.ts
@qiaozha qiaozha added the P1 priority 1 label Aug 20, 2025
@jeremymeng jeremymeng marked this pull request as ready for review October 31, 2025 16:37
@jeremymeng
Copy link
Copy Markdown
Member Author

Looks that CI checks were all passing. I don't know whether we have other places that is not in this repo where we still build using rush. If not I think it is good to merge.

Comment thread .scripts/nightly-prepare.yml
Comment thread package.json
"pnpm": ">=10.12.1"
},
"pnpm": {
"overrides": {},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls check if we need to add this global overrides.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's empty and does not do anything currently, but provide a place to add overrides in the future if needed.

Copy link
Copy Markdown
Member

@MaryGao MaryGao Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we have this requirement in nightly ci to upgrade to latest dev globally. JiaoDi will help verify if the global overrides work in nightly ci.

@MaryGao MaryGao merged commit 60eb9aa into Azure:main Dec 2, 2025
16 checks passed
Comment thread .scripts/ci.yml
workingDirectory: $(Build.SourcesDirectory)/packages/typespec-ts
- script: |
export TAR_NAME=$(node ../../common/scripts/install-run-rush-pnpm.js pack -q)
export TAR_NAME=$(pnpm pack -q)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will lead to invalid tar name so we can't release.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes in here #3627

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 priority 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants