Skip to content

Fix the missing parameters in operation options#3502

Merged
MaryGao merged 11 commits intoAzure:mainfrom
v-jiaodi:test-issue3501
Sep 26, 2025
Merged

Fix the missing parameters in operation options#3502
MaryGao merged 11 commits intoAzure:mainfrom
v-jiaodi:test-issue3501

Conversation

@v-jiaodi
Copy link
Copy Markdown
Member

fixes #3501

Comment thread packages/typespec-ts/src/modular/buildOperations.ts Outdated
Comment thread packages/typespec-ts/src/modular/helpers/operationHelpers.ts Outdated
@v-jiaodi v-jiaodi marked this pull request as ready for review September 24, 2025 08:28
Copy link
Copy Markdown
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We have spector cases for that, could you add it and remove the smoke test?

Comment thread packages/typespec-test/test/testOperation/spec/client.tsp
@@ -0,0 +1,28 @@
## API Report File for "@azure/keyvault-secrets"

Copy link
Copy Markdown
Member

@MaryGao MaryGao Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-jiaodi Pls remove this smoke testing when you add relevant spector cases.

@MaryGao MaryGao enabled auto-merge (squash) September 26, 2025 06:50
@MaryGao MaryGao merged commit e05d84b into Azure:main Sep 26, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Emitter Incorrectly uses original operation for implementation when generating an overridden (client.tsp) operation

2 participants