Fix flatten inconsistency between src and sample gen#3657
Merged
kazrael2119 merged 1 commit intoAzure:mainfrom Dec 23, 2025
Merged
Fix flatten inconsistency between src and sample gen#3657kazrael2119 merged 1 commit intoAzure:mainfrom
kazrael2119 merged 1 commit intoAzure:mainfrom
Conversation
MaryGao
changed the title
MaryGao
approved these changes
Dec 23, 2025
MaryGao
reviewed
Dec 23, 2025
| bazPropertiesBaz: [{ x: "bbb" }], | ||
| bar: [{ x: "xx" }], | ||
| bazPropertiesBaz: 222, | ||
| properties: { baz: 222 }, |
Member
There was a problem hiding this comment.
Pls double confirm this is aligned with model gen.
Member
Author
There was a problem hiding this comment.
this should be expected,
we should flatten the properties from the line 65, but not flatten the line 76
Member
Author
|
has tested the case from the issue, it could be expected by this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3653