Support array encoding for string-based enum types#3686
Merged
JialinHuang803 merged 6 commits intoAzure:mainfrom Jan 20, 2026
Merged
Support array encoding for string-based enum types#3686JialinHuang803 merged 6 commits intoAzure:mainfrom
JialinHuang803 merged 6 commits intoAzure:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for array encoding (CSV, pipe-delimited, space-delimited, newline-delimited) for string-based enum types in the TypeSpec TypeScript emitter. Previously, only plain string arrays supported collection format encoding.
Changes:
- Added
isStringEncodableArrayValueType()helper function to validate array value types that can use collection format encoding - Updated validation logic to accept both string types and string-based enum types for array encoding
- Enhanced deserialization logic to properly cast enum arrays with fixed members to the correct type
- Added comprehensive test coverage for various array encoding formats with enum and union types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/typespec-ts/src/modular/helpers/operationHelpers.ts | Implements support for string-based enum array encoding by adding type checking helper and updating deserialization logic |
| packages/typespec-ts/test/modularUnit/scenarios/models/serialization/modelPropertyArrayEncoding.md | Adds test cases for enum and union array encoding scenarios |
qiaozha
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support array encoding for string-based enum types.