Fix XML object serializer missing itemsName wrapping for arrays#3774
Merged
joheredi merged 1 commit intoAzure:mainfrom Feb 19, 2026
Merged
Conversation
The buildXmlObjectPropertyAssignments function was generating flat mappings
for array properties without wrapping items under their itemsName element.
This caused incorrect XML where array items were placed directly under the
wrapper element, missing the intermediate item element (e.g., <Field>).
For wrapped arrays, now generates: { "WrapperName": { "ItemsName": items } }
For unwrapped arrays, now generates: { "ItemsName": items }
Fixes Azure#3771
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
timovv
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
buildXmlObjectModelSerializer(used for nested models) was generating flat mappings for array propertieswithout wrapping items under their
itemsNameelement. This caused incorrect XML where array items were placeddirectly under the wrapper element, missing the intermediate item element.
For example, given:
Before (incorrect):
{ "Schema": items.map(...) }After (correct):{ "Schema": { "Field": items.map(...) } }Fix
Modified buildXmlObjectPropertyAssignments in buildXmlSerializerFunction.ts to read xmlOptions.itemsName and
xmlOptions.unwrapped for array properties and generate the correct nested structure.
Testing
Fixes #3771