Fix enum member names: use enum type name as prefix instead of _ for leading-digit identifiers

[Copilot]

Fixes enum member naming in the Modular SDK emitter to produce valid TypeScript identifiers when enum values start with digits or special characters.

Changes Made

• Enum type name prefix: emitEnumMember now computes enumTypeName internally from member.enumType.name (via normalizeName) instead of receiving it as a parameter, keeping the function signature clean.
• Deduplication of colliding names: Added deduplicateEnumMemberNames() in buildEnumTypes to handle cases where multiple enum values normalize to the same identifier (e.g. "10" and "1.0" both normalizing to ExtensibleString10). Conflicting names are disambiguated by appending _1, _2, ... suffixes (e.g. ExtensibleString10_1 and ExtensibleString10_2).
• Diagnostic reporting: A prefix-adding-in-enum-member warning is reported when a leading-digit member name is prefixed with the enum type name.
• Snapshot updates: Updated enumKeyNorm.md and extends.md scenario snapshots to reflect the new naming behavior.
• Smoke test regeneration: Regenerated all TypeSpec smoke test scenarios so the check:tree CI step passes with the new enum member names.

Testing

• All 599 modular unit tests pass.
• Snapshot tests updated and passing for affected scenarios.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>[emitter] Review comment with _0 to fix enum member names having a _ prefix</issue_title>
<issue_description>### Background
During the SDK release phase, we often receive review comments on public APIs that require the service team to modify the original specification and regenerate the SDK. This frequently leads to multiple rounds of back-and-forth discussions. It would be beneficial to revisit these cases and determine:

• Whether the issue can be addressed on the emitter side, or
• Whether the emitter or TCGC should report errors or diagnostics earlier or
• Whether we should NOT report this comment in review phase.

Review Comment

This is a case where the AI flags enum member names having _ prefix generated, which is unexpected. The _1 prefix is auto-added before any digit numbers which is not a valid typescript symbol and would cause compile failure.

• [AutoPR @azure-arm-previewalertrule]-generated-from-SDK Generation - JS-6033458 azure-sdk-for-js#37732 (comment)
• [AutoPR @azure-arm-previewalertrule]-generated-from-SDK Generation - JS-6026291 azure-sdk-for-js#37710 (comment)
• [AutoPR @azure-arm-alertsmanagement]-generated-from-SDK Generation - JS-6006122 azure-sdk-for-js#37633 (comment)

Suggestion

To give the enum member more valuable name, we plan to add enum type name as prefix not _ and also report a warning when detecting any non-valid enum member. This would only work for Modular.

</issue_description>

<agent_instructions>To give the enum member more valuable name, we plan to add enum type name as prefix not _ and also report a warning when detecting any non-valid enum member. This would only work for Modular.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes [emitter] Review comment with _0 to fix enum member names having a _ prefix #3859

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[MaryGao]

@copilot Could you take a look at the pipeline failure and try to fix then?

[Copilot]

@copilot Could you take a look at the pipeline failure and try to fix then?

The CI failure was in the TypeSpec_Smoke_Test stage's check:tree step. This step regenerates all TypeSpec smoke test scenarios and verifies the generated files match what's committed in git. Since my emitter changes produce different enum member names (e.g., Versions100 instead of _100), the regenerated files differed from the committed ones.

Fixed in commits 7f7ebc2 and e027d69 by:

1. Regenerating all 30 TypeSpec smoke test scenarios with the new enum member naming
2. Restoring the openai_non_branded scenario that was accidentally deleted (it uses a non-standard tspconfig.yaml path in spec/ rather than the root)

The check:tree now passes locally, confirming the generated files are in sync with the updated emitter behavior.

[v-jiaodi]

@copilot run pnpm smoke-test to fix ci under typespec-test folder

[Copilot]

@copilot run pnpm smoke-test to fix ci under typespec-test folder

Done in commit 33d2ecd. Ran pnpm smoke-test which regenerated 6 scenarios (NetworkAnalytics.Management, healthInsights_radiologyinsights, loadtesting_modular, nestedClient, openai_modular, schemaRegistry) that were affected by the merge from main. check:tree now passes cleanly.

[v-jiaodi]

@copilot pull main branch and resolve conflicts.

[Copilot]

@copilot pull main branch and resolve conflicts.

Done in commit 485c752. Merged main branch (PR #3810 - Report TCGC diagnostics) and resolved the conflict: enumUnion.spec.ts was deleted by main and the test was moved to diagnostics.spec.ts with the old message format. Updated diagnostics.spec.ts to use our new diagnostic message format with the enum type name as prefix. All tests pass and check:tree passes cleanly.

[v-jiaodi]

@copilot revert headerParamWithClientInitialization.md and storageCompatResponse.md file change.

[Copilot]

@copilot revert headerParamWithClientInitialization.md and storageCompatResponse.md file change.

Done in commit 6867008. Both files are restored to their original state — those were unrelated Prettier formatting changes that accidentally got included.