[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2021-03-01-preview#12554
Merged
akning-ms merged 229 commits intoAzure:masterfrom May 11, 2021
forteddyt:thtodoro/2021-03-01-preview
Merged
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2021-03-01-preview#12554akning-ms merged 229 commits intoAzure:masterfrom forteddyt:thtodoro/2021-03-01-preview
akning-ms merged 229 commits intoAzure:masterfrom
forteddyt:thtodoro/2021-03-01-preview
Conversation
… preview/2020-09-01-preview to version 2021-03-01-preview
|
Hi, @forteddyt Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vsswagger@microsoft.com |
Swagger Validation Report
|
| Rule | Message |
|---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/features' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L262:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/locations/{location}/Quotas' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L565:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces/skus' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1163:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/linkedServices' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1378:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/linkedServices/{linkName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1420:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1560:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services/{serviceName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L1632:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'LinkedServiceRequest' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2300:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'LinkedServiceProps' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2300:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ACIServiceResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/preview/2020-09-01-preview/machineLearningServices.json#L2300:3 |
️❌Cross Version BreakingChange (Base on stable version): 130 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.9)
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/features' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L262:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.MachineLearningServices/workspaces/skus' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L1217:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L1432:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/services/{serviceName}' removed or restructured? Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L1504:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'SystemData' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'IdentityType' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'ACIServiceResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'AKSVariantResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'AKSServiceResponse' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'CreateServiceRequest' removed or renamed? New: Microsoft.MachineLearningServices/preview/2021-03-01-preview/machineLearningServices.json#L1823:3 Old: Microsoft.MachineLearningServices/stable/2021-04-01/machineLearningServices.json#L2205:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 2 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"Schema 'AmlComputeNodesInformation' has a property 'nextLink' that is already declared the parent schema 'ComputeNodesInformation' but isn't significantly different. The property has been removed from AmlComputeNodesInformation" |
|
| "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"The schema 'components·1dsxf3l·schemas·commandjob·properties·parameters·additionalproperties' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2021-03-01-preview/mfe.json#/components/schemas/components·1dsxf3l·schemas·commandjob·properties·parameters·additionalproperties" |
|
| 💬 AutorestCore/Exception | "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-2021-03-01-preview", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
|
Hi, @forteddyt your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). cc @ |
|
Hi @forteddyt, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 21, 2021
…ure-rest-api-specs into thtodoro/2021-03-01-preview
ArcturusZhang
approved these changes
May 10, 2021
Member
|
@msyyc could you please take a look at the python SDK breaking changes? |
Member
|
For python, the breaking change is ok |
ArcturusZhang
approved these changes
May 11, 2021
This was referenced May 11, 2021
This was referenced Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.