[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2022-08-11-preview by ankjayant · Pull Request #20502 · Azure/azure-rest-api-specs

ankjayant · 2022-08-31T16:21:06Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…022-05-10-preview to version 2022-08-11-preview

openapi-workflow-bot · 2022-08-31T16:21:09Z

Hi, @ankjayant Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2022-08-31T16:21:11Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️🔄Breaking Change(Cross-Version) inProgress [Detail]

️⌛CredScan pending [Detail]

️🔄LintDiff inProgress [Detail]

️⌛Avocado pending [Detail]

️⌛ApiReadinessCheck pending [Detail]

️⌛~[Staging] ServiceAPIReadinessTest pending [Detail]

️⌛~[Staging] TrafficValidation pending [Detail]

️⌛ModelValidation pending [Detail]

️🔄SemanticValidation inProgress [Detail]

️⌛PoliCheck pending [Detail]

️⌛SDK Track2 Validation pending [Detail]

️⌛PrettierCheck pending [Detail]

️⌛SpellCheck pending [Detail]

️⌛Lint(RPaaS) pending [Detail]

️⌛CadlValidation pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-08-31T16:21:12Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/hybridcompute/armhybridcompute - Approved - 2.0.0-beta.1

+	Field `Extensions` of struct `MachineProperties` has been removed
+	Type of `MachineExtensionProperties.ProtectedSettings` has been changed from `interface{}` to `map[string]interface{}`
+	Type of `MachineExtensionProperties.Settings` has been changed from `interface{}` to `map[string]interface{}`
+	Type of `MachineExtensionUpdateProperties.ProtectedSettings` has been changed from `interface{}` to `map[string]interface{}`
+	Type of `MachineExtensionUpdateProperties.Settings` has been changed from `interface{}` to `map[string]interface{}`

❌azure-sdk-for-python-track2 - track2_azure-mgmt-hybridcompute - 7.0.0

+	Model Machine no longer has parameter properties
+	Model MachineExtension no longer has parameter properties
+	Model MachineExtensionUpdate no longer has parameter properties
+	Model MachineUpdate no longer has parameter properties

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 94ca9bf. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION --use=@microsoft.azure/autorest.csharp@2.3.82 --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/hybridcompute/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] No usable version of the libssl was found
cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 94ca9bf. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.15.0 -> 8.19.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.19.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@8.19.2` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-hybridcompute [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Added operation group ExtensionMetadataOperations
info	[Changelog]   - Added operation group HybridComputeManagementClientOperationsMixin
info	[Changelog]   - Model HybridComputePrivateLinkScopeProperties has a new parameter private_endpoint_connections
info	[Changelog]   - Model Machine has a new parameter ad_fqdn
info	[Changelog]   - Model Machine has a new parameter agent_configuration
info	[Changelog]   - Model Machine has a new parameter agent_version
info	[Changelog]   - Model Machine has a new parameter client_public_key
info	[Changelog]   - Model Machine has a new parameter cloud_metadata
info	[Changelog]   - Model Machine has a new parameter detected_properties
info	[Changelog]   - Model Machine has a new parameter display_name
info	[Changelog]   - Model Machine has a new parameter dns_fqdn
info	[Changelog]   - Model Machine has a new parameter domain_name
info	[Changelog]   - Model Machine has a new parameter error_details
info	[Changelog]   - Model Machine has a new parameter last_status_change
info	[Changelog]   - Model Machine has a new parameter location_data
info	[Changelog]   - Model Machine has a new parameter machine_fqdn
info	[Changelog]   - Model Machine has a new parameter mssql_discovered
info	[Changelog]   - Model Machine has a new parameter os_name
info	[Changelog]   - Model Machine has a new parameter os_profile
info	[Changelog]   - Model Machine has a new parameter os_sku
info	[Changelog]   - Model Machine has a new parameter os_type
info	[Changelog]   - Model Machine has a new parameter os_version
info	[Changelog]   - Model Machine has a new parameter parent_cluster_resource_id
info	[Changelog]   - Model Machine has a new parameter private_link_scope_resource_id
info	[Changelog]   - Model Machine has a new parameter provisioning_state
info	[Changelog]   - Model Machine has a new parameter resources
info	[Changelog]   - Model Machine has a new parameter service_statuses
info	[Changelog]   - Model Machine has a new parameter status
info	[Changelog]   - Model Machine has a new parameter vm_id
info	[Changelog]   - Model Machine has a new parameter vm_uuid
info	[Changelog]   - Model MachineExtension has a new parameter auto_upgrade_minor_version
info	[Changelog]   - Model MachineExtension has a new parameter enable_automatic_upgrade
info	[Changelog]   - Model MachineExtension has a new parameter force_update_tag
info	[Changelog]   - Model MachineExtension has a new parameter instance_view
info	[Changelog]   - Model MachineExtension has a new parameter protected_settings
info	[Changelog]   - Model MachineExtension has a new parameter provisioning_state
info	[Changelog]   - Model MachineExtension has a new parameter publisher
info	[Changelog]   - Model MachineExtension has a new parameter settings
info	[Changelog]   - Model MachineExtension has a new parameter type_handler_version
info	[Changelog]   - Model MachineExtension has a new parameter type_properties_type
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter auto_upgrade_minor_version
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter enable_automatic_upgrade
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter force_update_tag
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter protected_settings
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter publisher
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter settings
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type
info	[Changelog]   - Model MachineExtensionUpdate has a new parameter type_handler_version
info	[Changelog]   - Model MachineUpdate has a new parameter cloud_metadata
info	[Changelog]   - Model MachineUpdate has a new parameter location_data
info	[Changelog]   - Model MachineUpdate has a new parameter os_profile
info	[Changelog]   - Model MachineUpdate has a new parameter parent_cluster_resource_id
info	[Changelog]   - Model MachineUpdate has a new parameter private_link_scope_resource_id
info	[Changelog]   - Model OSProfile has a new parameter linux_configuration
info	[Changelog]   - Model OSProfile has a new parameter windows_configuration
info	[Changelog]   - Model OperationValue has a new parameter is_data_action
info	[Changelog]   - Model PrivateEndpointConnectionProperties has a new parameter group_ids
info	[Changelog]   - Model ProxyResource has a new parameter system_data
info	[Changelog]   - Model Resource has a new parameter system_data
info	[Changelog]   - Model TrackedResource has a new parameter system_data
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model Machine no longer has parameter properties
info	[Changelog]   - Model MachineExtension no longer has parameter properties
info	[Changelog]   - Model MachineExtensionUpdate no longer has parameter properties
info	[Changelog]   - Model MachineUpdate no longer has parameter properties

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 94ca9bf. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-hybridcompute [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 94ca9bf. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/hybridcompute/armhybridcompute [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `MachineExtensionProperties.ProtectedSettings` has been changed from `interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `MachineExtensionProperties.Settings` has been changed from `interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `MachineExtensionUpdateProperties.Settings` has been changed from `interface{}` to `map[string]interface{}`
info	[Changelog] - Type of `MachineExtensionUpdateProperties.ProtectedSettings` has been changed from `interface{}` to `map[string]interface{}`
info	[Changelog] - Field `Extensions` of struct `MachineProperties` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `AgentConfigurationModeMonitor`
info	[Changelog] - New const `AgentConfigurationModeFull`
info	[Changelog] - New type alias `AgentConfigurationMode`
info	[Changelog] - New function `NewExtensionMetadataClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ExtensionMetadataClient, error)`
info	[Changelog] - New function `PossibleAgentConfigurationModeValues() []AgentConfigurationMode`
info	[Changelog] - New function `*ExtensionMetadataClient.Get(context.Context, string, string, string, string, *ExtensionMetadataClientGetOptions) (ExtensionMetadataClientGetResponse, error)`
info	[Changelog] - New function `*ExtensionMetadataClient.NewListPager(string, string, string, *ExtensionMetadataClientListOptions) *runtime.Pager[ExtensionMetadataClientListResponse]`
info	[Changelog] - New struct `ErrorDetailAutoGenerated`
info	[Changelog] - New struct `ErrorResponseAutoGenerated`
info	[Changelog] - New struct `ExtensionMetadataClient`
info	[Changelog] - New struct `ExtensionMetadataClientGetOptions`
info	[Changelog] - New struct `ExtensionMetadataClientGetResponse`
info	[Changelog] - New struct `ExtensionMetadataClientListOptions`
info	[Changelog] - New struct `ExtensionMetadataClientListResponse`
info	[Changelog] - New struct `ExtensionValue`
info	[Changelog] - New struct `ExtensionValueListResult`
info	[Changelog] - New struct `ExtensionValueProperties`
info	[Changelog] - New field `SystemData` in struct `Resource`
info	[Changelog] - New field `SystemData` in struct `ProxyResource`
info	[Changelog] - New field `ConfigMode` in struct `AgentConfiguration`
info	[Changelog] - New field `EnableAutomaticUpgrade` in struct `MachineExtensionUpdateProperties`
info	[Changelog] - New field `Resources` in struct `Machine`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 3 breaking change(s), 33 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 94ca9bf. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-hybridcompute [View full logs] [Release SDK Changes]

azure-arm-hybridcompute-3.1.0-beta.2.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ExtensionMetadata
info	[Changelog]   - Added Interface AgentConfiguration
info	[Changelog]   - Added Interface CloudMetadata
info	[Changelog]   - Added Interface ConfigurationExtension
info	[Changelog]   - Added Interface ErrorDetailAutoGenerated
info	[Changelog]   - Added Interface ErrorResponseAutoGenerated
info	[Changelog]   - Added Interface ExtensionMetadataGetOptionalParams
info	[Changelog]   - Added Interface ExtensionMetadataListOptionalParams
info	[Changelog]   - Added Interface ExtensionValue
info	[Changelog]   - Added Interface ExtensionValueListResult
info	[Changelog]   - Added Interface HybridComputePrivateLinkScope
info	[Changelog]   - Added Interface Machine
info	[Changelog]   - Added Interface MachineExtension
info	[Changelog]   - Added Interface MachineExtensionUpdate
info	[Changelog]   - Added Interface MachineUpdate
info	[Changelog]   - Added Interface OSProfileLinuxConfiguration
info	[Changelog]   - Added Interface OSProfileWindowsConfiguration
info	[Changelog]   - Added Interface PrivateEndpointConnection
info	[Changelog]   - Added Interface PrivateEndpointConnectionDataModel
info	[Changelog]   - Added Interface PrivateLinkResource
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Added Interface ServiceStatus
info	[Changelog]   - Added Interface ServiceStatuses
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Type Alias AgentConfigurationMode
info	[Changelog]   - Added Type Alias AssessmentModeTypes
info	[Changelog]   - Added Type Alias ExtensionMetadataGetResponse
info	[Changelog]   - Added Type Alias ExtensionMetadataListResponse
info	[Changelog]   - Added Type Alias PatchModeTypes
info	[Changelog]   - Interface HybridComputePrivateLinkScopeProperties has a new optional parameter privateEndpointConnections
info	[Changelog]   - Interface OperationValue has a new optional parameter isDataAction
info	[Changelog]   - Interface OSProfile has a new optional parameter linuxConfiguration
info	[Changelog]   - Interface OSProfile has a new optional parameter windowsConfiguration
info	[Changelog]   - Interface PrivateEndpointConnectionProperties has a new optional parameter groupIds
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Class HybridComputeManagementClient has a new parameter extensionMetadata
info	[Changelog]   - Added Enum KnownAgentConfigurationMode
info	[Changelog]   - Added Enum KnownAssessmentModeTypes
info	[Changelog]   - Added Enum KnownPatchModeTypes

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 94ca9bf. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️hybridcompute [View full logs] [Release Schema Changes]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 94ca9bf. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.HybridCompute [View full logs] [Release SDK Changes]
- Az.HybridCompute.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-08-31T16:21:13Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/hybridcompute/armhybridcompute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Python	track2_azure-mgmt-hybridcompute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-hybridcompute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-hybridcompute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2022-08-31T16:24:21Z

Hi @ankjayant, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

raghushantha · 2022-08-31T18:32:45Z

@ankjayant - Ensure you have examples for the new API in the PR

openapi-workflow-bot · 2022-08-31T19:26:42Z

Hi @ankjayant, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-09-02T00:38:42Z

Hi, @ankjayant your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

mentat9 · 2022-09-30T17:32:02Z

+      },
+      "description": "The List Extension Metadata response."
+    },
+    "ExtensionValue": {


ExtensionValue

Why did you replace the ProxyResource definition with id and location? You also need "type" as a minimum, but using the common type definition is much better. If you aren't ready for this resource to have systemData, you can use ProxyResource from v2 common types. #Resolved

I am a little confused as to what you mean by replacing the proxyresource definition, can you elaborate on the issue a little further and tell me what needs to get done to resolve it?

At commit 12 this definition included a $ref to v1 common types definition ProxyResource which has the required top-level properties id, name, and type. Now that $ref is gone, and an id and name property are added in this definition. Recommendation to fix it is to add a $ref to the ProxyResource definition in v3 common types and remove the id and name from this definition.

@mentat9 - Thank you Chris.
Updated to include ProxyResource v3 common-type.
Lmk if this looks good

Update readme.python.md

ankjayant added 3 commits August 11, 2022 11:04

Adds base for updating Microsoft.HybridCompute from version preview/2…

d091788

…022-05-10-preview to version 2022-08-11-preview

Updates readme

cbe000e

Updates API version in new specs and examples

bb83cff

openapi-pipeline-app Bot added resource-manager BreakingChangeReviewRequired labels Aug 31, 2022

azure-sdk mentioned this pull request Aug 31, 2022

[AutoPR sdk/resourcemanager/hybridcompute/armhybridcompute] [Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2022-08-11-preview azure-sdk/azure-sdk-for-go#2615

Closed

openapi-pipeline-app Bot added the CI-BreakingChange-Go label Aug 31, 2022

openapi-pipeline-app Bot added the CI-BreakingChange-Python-Track2 label Aug 31, 2022

openapi-pipeline-app Bot added the CI-BreakingChange-JavaScript label Aug 31, 2022

azure-sdk mentioned this pull request Aug 31, 2022

[AutoPR Az.HybridCompute] [Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2022-08-11-preview azure-sdk/azure-powershell#2120

Closed

openapi-pipeline-app Bot added the CI-FixRequiredOnFailure label Aug 31, 2022

dorothyhu force-pushed the dev-hybridcompute-Microsoft.HybridCompute-2022-08-11-preview branch from d8e5760 to 6edca07 Compare September 1, 2022 21:36

openapi-workflow-bot Bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 2, 2022

dorothyhu force-pushed the dev-hybridcompute-Microsoft.HybridCompute-2022-08-11-preview branch from 25c83bc to 289c8b5 Compare September 2, 2022 00:50

dorothyhu marked this pull request as ready for review September 2, 2022 01:31

mentat9 reviewed Sep 30, 2022

View reviewed changes

mentat9 added ARMChangesRequested and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Sep 30, 2022

openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 30, 2022

Merge pull request #1 from msyyc/patch-6

b10d6de

Update readme.python.md

raghushantha requested a review from BigCat20196 as a code owner September 30, 2022 18:18

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 30, 2022

Update readme.go.md

bc2aa6d

raghushantha requested a review from mentat9 September 30, 2022 22:02

Added ProxyResource common type to ExtensionValue definition

bbbe36d

AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Oct 1, 2022

raghushantha added 5 commits October 1, 2022 10:53

Add location in the ExtensionValue defn

39c86d8

Fix syntax error

c52f272

Fix linit error by removing location property

593a707

Remove location

938ca5c

Remove location

a58f864

AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Oct 1, 2022

Prettyfy json

79fac3a

raghushantha removed the ARMChangesRequested label Oct 1, 2022

openapi-workflow-bot Bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 1, 2022

mentat9 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 3, 2022

openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 3, 2022

jianyexi approved these changes Oct 11, 2022

View reviewed changes

tadelesh mentioned this pull request Apr 17, 2023

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2023-03-15-preview #22933

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2022-08-11-preview#20502

[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2022-08-11-preview#20502
jianyexi merged 27 commits intoAzure:mainfrom
ankjayant:dev-hybridcompute-Microsoft.HybridCompute-2022-08-11-preview

ankjayant commented Aug 31, 2022 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Aug 31, 2022

Uh oh!

openapi-pipeline-app Bot commented Aug 31, 2022 •

edited

Loading

Uh oh!

openapi-pipeline-app Bot commented Aug 31, 2022 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Aug 31, 2022 •

edited

Loading

Uh oh!

openapi-workflow-bot Bot commented Aug 31, 2022

Uh oh!

raghushantha commented Aug 31, 2022

Uh oh!

openapi-workflow-bot Bot commented Aug 31, 2022

Uh oh!

openapi-workflow-bot Bot commented Sep 2, 2022

Uh oh!

mentat9 Sep 30, 2022 •

edited

Loading

Uh oh!

ankjayant Sep 30, 2022

Uh oh!

mentat9 Oct 1, 2022

Uh oh!

raghushantha Oct 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Conversation

ankjayant commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

Uh oh!

openapi-workflow-bot Bot commented Aug 31, 2022

Uh oh!

openapi-pipeline-app Bot commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Aug 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot Bot commented Aug 31, 2022

Uh oh!

raghushantha commented Aug 31, 2022

Uh oh!

openapi-workflow-bot Bot commented Aug 31, 2022

Uh oh!

openapi-workflow-bot Bot commented Sep 2, 2022

Uh oh!

mentat9 Sep 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ankjayant Sep 30, 2022

Choose a reason for hiding this comment

Uh oh!

mentat9 Oct 1, 2022

Choose a reason for hiding this comment

Uh oh!

raghushantha Oct 1, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

ankjayant commented Aug 31, 2022 •

edited

Loading

openapi-pipeline-app Bot commented Aug 31, 2022 •

edited

Loading

openapi-pipeline-app Bot commented Aug 31, 2022 •

edited

Loading

openapi-pipeline-app Bot commented Aug 31, 2022 •

edited

Loading

mentat9 Sep 30, 2022 •

edited

Loading