Skip to content

Add new stable API-version 2023-05-01 in Microsoft.Dataprotection#24011

Merged
rkmanda merged 10 commits intoAzure:mainfrom
Shashank1306s:main
Jun 30, 2023
Merged

Add new stable API-version 2023-05-01 in Microsoft.Dataprotection#24011
rkmanda merged 10 commits intoAzure:mainfrom
Shashank1306s:main

Conversation

@Shashank1306s
Copy link
Copy Markdown
Contributor

@Shashank1306s Shashank1306s commented May 16, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @Shashank1306s Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 16, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 16 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    dataprotection.json 2023-05-01(753c9ce) 2023-01-01(main)
    dataprotection.json 2023-05-01(753c9ce) 2023-04-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchSecondaryRecoveryPoints' removed or restructured?
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1531:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/crossRegionRestore' removed or restructured?
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1606:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/validateCrossRegionRestore' removed or restructured?
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1684:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchCrossRegionRestoreJob' removed or restructured?
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1762:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchCrossRegionRestoreJobs' removed or restructured?
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1818:5
    ⚠️ 1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/{resourceId}/providers/Microsoft.DataProtection/backupInstances' removed or restructured?
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1877:5
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreJobRequest' removed or renamed?
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreJobsRequest' removed or renamed?
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'FetchSecondaryRPsRequestParameters' removed or renamed?
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreDetails' removed or renamed?
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'ValidateCrossRegionRestoreRequestObject' removed or renamed?
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3
    ⚠️ 1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreRequestObject' removed or renamed?
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3
    ⚠️ 1007 - RemovedClientParameter The new version is missing a client parameter that was found in the old version. Was 'ResourceId' removed or renamed?
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L7467:3
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L7912:3
    ⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
    New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L5520:11
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5920:11
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v4/managedidentity.json#L27:9
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5932:9
    ⚠️ 1023 - TypeFormatChanged The new version has a different format than the previous one.
    New: common-types/resource-management/v4/managedidentity.json#L21:9
    Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5937:9
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.3) new version base version
    package-2023-05 package-2023-05(753c9ce) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L42
    LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L64
    ParametersOrder The parameters:operationId,location should be kept in the same order as they present in the path.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L64
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L94
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L184
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L307
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L328
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L410
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L426
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L467
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L476
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L526
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L532
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L544
    LroExtension Operations with a 202 response must specify x-ms-long-running-operation: true.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L545
    GetOperation200 The get operation should only return 200.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L580
    OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L740
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L761
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L788
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L809
    ResourceNameRestriction The resource name parameter 'backupPolicyName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L809
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L899
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L969
    GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L996
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1017
    ResourceNameRestriction The resource name parameter 'backupInstanceName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1017
    PutResponseSchemaDescription Description of 200 response code of a PUT operation MUST include term 'update'.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1099
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1128
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1193
    ResourceNameRestriction The resource name parameter 'vaultName' should be defined with a 'pattern' restriction.
    Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1205
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 43 Errors, 0 Warnings failed [Detail]

    Tag package-2023-05; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 66, untested: 0, failed: 43, passed: 23

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    CLIENT_ERROR statusCode: 400,
    errorCode: BMSUserErrorInvalidInput,
    errorMessage: The user input given for the call is invalid
    Source: runtime
    OperationId: BackupVaults_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupVaults_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupVaults_Update
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_GetBackupInstanceOperationResult
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_AdhocBackup
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/backupInstances/validateRestore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9/backupInstances/backupin7gmp2c'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/testdb' or the linked scope(s) are invalid.
    Source: runtime
    OperationId: BackupInstances_ValidateForRestore
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_SyncBackupInstance
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_SuspendBackups
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_StopProtection
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_ResumeBackups
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_ResumeProtection
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/backupInstances/restore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9/backupInstances/backupin7gmp2c'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/testdb' or the linked scope(s) are invalid.
    Source: runtime
    OperationId: BackupInstances_TriggerRestore
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/validateForBackup/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest' or the linked scope(s) are invalid.
    Source: runtime
    OperationId: BackupInstances_ValidateForBackup
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupInstances_TriggerRehydrate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DppResourceGuardProxy_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DppResourceGuardProxy_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: DppResourceGuardProxy_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: LinkedAuthorizationFailed,
    errorMessage: The client has permission to perform action 'Microsoft.DataProtection/resourceGuards/deleteBackupInstanceRequests/approve/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9/backupResourceGuardProxies/resourceqskvjy', however the linked subscription 'f9e67185-f313-4e79-aa71-6458d429369d' was not found.
    Source: runtime
    OperationId: DppResourceGuardProxy_UnlockDelete
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupPolicies_CreateOrUpdate
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupPolicies_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: BackupPolicies_Get
    CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DataProtection/locations/checkFeatureSupport/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: DataProtection_CheckFeatureSupport
    CLIENT_ERROR statusCode: 400,
    errorCode: BMSUserErrorInvalidInput,
    errorMessage: The user input given for the call is invalid
    Source: runtime
    OperationId: OperationResult_Get
    CLIENT_ERROR statusCode: 400,
    errorCode: BMSUserErrorInvalidInput,
    errorMessage: The user input given for the call is invalid
    Source: runtime
    OperationId: OperationStatus_Get
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: RestorableTimeRanges_Find
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: RecoveryPoints_List
    CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: RecoveryPoints_Get
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 16, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking



    azure-sdk-for-js - @azure/arm-dataprotection - Approved - 2.0.0
    +	Class DataProtectionClient has a new signature
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from d75abbd. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.DataProtectionBackup [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.DataProtectionBackup.Models.DataProtectionBackupCrossSubscriptionRestoreState> Azure.ResourceManager.DataProtectionBackup.Models.DataProtectionBackupVaultProperties.CrossSubscriptionRestoreState.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/dataprotection/Azure.ResourceManager.DataProtectionBackup/src/Azure.ResourceManager.DataProtectionBackup.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.DataProtectionBackup.Models.DataProtectionBackupVaultProperties.CrossSubscriptionRestoreState.set(System.Nullable<Azure.ResourceManager.DataProtectionBackup.Models.DataProtectionBackupCrossSubscriptionRestoreState>)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/dataprotection/Azure.ResourceManager.DataProtectionBackup/src/Azure.ResourceManager.DataProtectionBackup.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.DataProtectionBackup/Debug/netstandard2.0/Azure.ResourceManager.DataProtectionBackup.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/dataprotection/Azure.ResourceManager.DataProtectionBackup/src/Azure.ResourceManager.DataProtectionBackup.csproj::TargetFramework=netstandard2.0]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d75abbd. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.7.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.7.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.7.2` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-dataprotection [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model AzureBackupJob has a new parameter rehydration_priority
      info	[Changelog]   - Model AzureBackupRecoveryPointBasedRestoreRequest has a new parameter identity_details
      info	[Changelog]   - Model AzureBackupRecoveryTimeBasedRestoreRequest has a new parameter identity_details
      info	[Changelog]   - Model AzureBackupRestoreRequest has a new parameter identity_details
      info	[Changelog]   - Model AzureBackupRestoreWithRehydrationRequest has a new parameter identity_details
      info	[Changelog]   - Model BackupInstance has a new parameter identity_details
      info	[Changelog]   - Model BackupVault has a new parameter secure_score
      info	[Changelog]   - Model Datasource has a new parameter resource_properties
      info	[Changelog]   - Model DatasourceSet has a new parameter resource_properties
      info	[Changelog]   - Model DeletedBackupInstance has a new parameter identity_details
      info	[Changelog]   - Model DppIdentityDetails has a new parameter user_assigned_identities
      info	[Changelog]   - Model FeatureSettings has a new parameter cross_region_restore_settings
      info	[Changelog]   - Model KubernetesClusterBackupDatasourceParameters has a new parameter backup_hook_references
      info	[Changelog]   - Model KubernetesClusterRestoreCriteria has a new parameter restore_hook_references
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d75abbd. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-dataprotection [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d75abbd. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/dataprotection/armdataprotection [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New enum type `CrossRegionRestoreState` with values `CrossRegionRestoreStateDisabled`, `CrossRegionRestoreStateEnabled`
      info	[Changelog] - New enum type `SecureScoreLevel` with values `SecureScoreLevelAdequate`, `SecureScoreLevelMaximum`, `SecureScoreLevelMinimum`, `SecureScoreLevelNone`, `SecureScoreLevelNotSupported`
      info	[Changelog] - New function `*BaseResourceProperties.GetBaseResourceProperties() *BaseResourceProperties`
      info	[Changelog] - New struct `CrossRegionRestoreSettings`
      info	[Changelog] - New struct `IdentityDetails`
      info	[Changelog] - New struct `NamespacedNameResource`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New field `RehydrationPriority` in struct `AzureBackupJob`
      info	[Changelog] - New field `IdentityDetails` in struct `AzureBackupRecoveryPointBasedRestoreRequest`
      info	[Changelog] - New field `IdentityDetails` in struct `AzureBackupRecoveryTimeBasedRestoreRequest`
      info	[Changelog] - New field `IdentityDetails` in struct `AzureBackupRestoreRequest`
      info	[Changelog] - New field `IdentityDetails` in struct `AzureBackupRestoreWithRehydrationRequest`
      info	[Changelog] - New field `IdentityDetails` in struct `BackupInstance`
      info	[Changelog] - New field `SecureScore` in struct `BackupVault`
      info	[Changelog] - New field `ResourceProperties` in struct `Datasource`
      info	[Changelog] - New field `ResourceProperties` in struct `DatasourceSet`
      info	[Changelog] - New field `IdentityDetails` in struct `DeletedBackupInstance`
      info	[Changelog] - New field `UserAssignedIdentities` in struct `DppIdentityDetails`
      info	[Changelog] - New field `CrossRegionRestoreSettings` in struct `FeatureSettings`
      info	[Changelog] - New field `BackupHookReferences` in struct `KubernetesClusterBackupDatasourceParameters`
      info	[Changelog] - New field `RestoreHookReferences` in struct `KubernetesClusterRestoreCriteria`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 33 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d75abbd. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-dataprotection [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added Interface BaseResourceProperties
      info	[Changelog]   - Added Interface CrossRegionRestoreSettings
      info	[Changelog]   - Added Interface IdentityDetails
      info	[Changelog]   - Added Interface NamespacedNameResource
      info	[Changelog]   - Added Interface UserAssignedIdentity
      info	[Changelog]   - Added Type Alias CrossRegionRestoreState
      info	[Changelog]   - Added Type Alias SecureScoreLevel
      info	[Changelog]   - Interface AzureBackupJob has a new optional parameter rehydrationPriority
      info	[Changelog]   - Interface AzureBackupRestoreRequest has a new optional parameter identityDetails
      info	[Changelog]   - Interface BackupInstance has a new optional parameter identityDetails
      info	[Changelog]   - Interface BackupVault has a new optional parameter secureScore
      info	[Changelog]   - Interface Datasource has a new optional parameter resourceProperties
      info	[Changelog]   - Interface DatasourceSet has a new optional parameter resourceProperties
      info	[Changelog]   - Interface DppIdentityDetails has a new optional parameter userAssignedIdentities
      info	[Changelog]   - Interface FeatureSettings has a new optional parameter crossRegionRestoreSettings
      info	[Changelog]   - Interface KubernetesClusterBackupDatasourceParameters has a new optional parameter backupHookReferences
      info	[Changelog]   - Interface KubernetesClusterRestoreCriteria has a new optional parameter restoreHookReferences
      info	[Changelog]   - Added Enum KnownCrossRegionRestoreState
      info	[Changelog]   - Added Enum KnownSecureScoreLevel
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Class DataProtectionClient has a new signature
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from d75abbd. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.dataprotection.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.dataprotection.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 16, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/dataprotection/armdataprotection https://apiview.dev/Assemblies/Review/8b72ff51fe6643b2896dbd6f2272c30d
    JavaScript @azure/arm-dataprotection https://apiview.dev/Assemblies/Review/65c8e654089d4140bbe1a4986eb12ff7
    Java azure-resourcemanager-dataprotection https://apiview.dev/Assemblies/Review/3f5c48370d7a4dc0b510341e84b7b6d7
    .Net Azure.ResourceManager.DataProtectionBackup https://apiview.dev/Assemblies/Review/58f785dcb8f547ecbe35d449a0a5d43b

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi, @Shashank1306s, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Hi, @Shashank1306s your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com).

    @Shashank1306s Shashank1306s marked this pull request as ready for review May 26, 2023 08:08
    @visingla-ms
    Copy link
    Copy Markdown
    Contributor

    "IdentityDetails": {
    

    Instead of defining it here, use "ManagedServiceIdentity" from common-types: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/managedidentity.json.


    Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-05-01/dataprotection.json:4321 in 26675d4. [](commit_id = 26675d4, deletion_comment = False)

    @visingla-ms
    Copy link
    Copy Markdown
    Contributor

    "UserAssignedIdentityDetails": {
    

    See https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/managedidentity.json.


    Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-05-01/dataprotection.json:5500 in 26675d4. [](commit_id = 26675d4, deletion_comment = False)

    @visingla-ms
    Copy link
    Copy Markdown
    Contributor

    "NamespacedNameResource": {
    

    Resource Name seems a bit confusing.


    Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-05-01/dataprotection.json:6372 in 26675d4. [](commit_id = 26675d4, deletion_comment = False)

    @openapi-workflow-bot
    Copy link
    Copy Markdown

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 26, 2023
    @Shashank1306s
    Copy link
    Copy Markdown
    Contributor Author

    6372

    Hi @visingla-ms, NamespacedNameResource is defined in common contract and it defines those resources which are identified by both namespace and its name.

    @ankur741999
    Copy link
    Copy Markdown
    Contributor

    Here in one of the required checks: Swagger ModelValidation.. I can see failure's
    Basically we have added one field in Backup Vault Property and its a read-only property.. however there is a requirement that whatever response we get as part of GET, should work as part of PUT as well.. therefore we have kept the field as part of PUT request as well. Current Behaviour is set in a way that it would ignore that field.

    Customer can send this sometimes and instead of failing the call we would just ignore it..

    Before finalizing this we posted this on stack overflow and this was one of the recommended way of handling such properties.
    https://stackoverflow.microsoft.com/questions/347097

    @scbedd
    Copy link
    Copy Markdown
    Member

    scbedd commented Jun 13, 2023

    @keryul Does suppressing this error follow with your experience? Do you happen to know who would be the swagger SME that I talk to about changes that I make to oav to support this scenario? Or is this a case of actual error that we just ignore.

    I haven't see any exclusion about error READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST. Let's see if there's any exclusion in #23391.

    I don't understand what you mean by

    let's see if there's any exclusion in #23391

    Do you mean there is no prior art of a suppression on this type of error? Or that the other PR has an exclusion within it that we can copy?

    @amchandn
    Copy link
    Copy Markdown
    Contributor

    Basically we have added one field in Backup Vault Property and its a read-only property.. however there is a requirement that whatever response we get as part of GET, should work as part of PUT as well.. therefore we have kept the field as part of PUT request as well. Current Behaviour is set in a way that it would ignore that field.

    I'm looking at this model validation failure...and the failure makes sense. If that property is marked readOnly, it can't be set from client side.
    I will allocate a couple hours on Monday morning first-thing to see if I can understand your use-case and come up with a workaround.

    @scbedd , many users do a Get-Resource API and use the response of the same to do update resource (via PUT) by modifying 1-2 properties' values. Hence, to avoid failures for those users, we have the example with readonly property allowed in request. Let me know if it makes sense. This change was approved as part of our changes in preview API version.
    PR link for preview version - #23391

    @amchandn can you tag the example with readonly property allowed in request? Let's find if there's a exclusion for this situation.

    Hi @keryul , @scbedd , looks like a force push by the PR author undoe'd the concerned change. We're making that change again and will update the conversation in this PR.
    Thanks for your patience.

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented Jun 14, 2023

    @keryul Does suppressing this error follow with your experience? Do you happen to know who would be the swagger SME that I talk to about changes that I make to oav to support this scenario? Or is this a case of actual error that we just ignore.

    I haven't see any exclusion about error READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST. Let's see if there's any exclusion in #23391.

    I don't understand what you mean by

    let's see if there's any exclusion in #23391

    Do you mean there is no prior art of a suppression on this type of error? Or that the other PR has an exclusion within it that we can copy?

    I want to know if that PR has an exclusion within it that we can copy cause I haven't found any readOnly property in request in that PR.

    @amchandn
    Copy link
    Copy Markdown
    Contributor

    @keryul Does suppressing this error follow with your experience? Do you happen to know who would be the swagger SME that I talk to about changes that I make to oav to support this scenario? Or is this a case of actual error that we just ignore.

    I haven't see any exclusion about error READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST. Let's see if there's any exclusion in #23391.

    I don't understand what you mean by

    let's see if there's any exclusion in #23391

    Do you mean there is no prior art of a suppression on this type of error? Or that the other PR has an exclusion within it that we can copy?

    I want to know if that PR has an exclusion within it that we can copy cause I haven't found any readOnly property in request in that PR.

    @keryul , @scbedd , here is the failing example and readonly property that is failing check during ModelValidation with examples

    `

    READONLY_PROPERTY_NOT_ALLOWED_IN_REQUEST ReadOnly property "secureScore" cannot be sent in the requestUrl: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L4835:24ExampleUrl: 2023-05-01/examples/VaultCRUD/PutBackupVault.json#L7:19

    Failing validation link
    `

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented Jun 14, 2023

    Let me know if it makes sense. This change was approved as part of our changes in preview API version.

    @amchandn Did I misunderstand the phrase? If this change was approved in preview PR, we will try to approved it in this PR. Or if not, we still think you should fix the MV error.

    @amchandn
    Copy link
    Copy Markdown
    Contributor

    Let me know if it makes sense. This change was approved as part of our changes in preview API version.

    @amchandn Did I misunderstand the phrase? If this change was approved in preview PR, we will try to approved it in this PR. Or if not, we still think you should fix the MV error.

    Yes, this change was approved as part of preview API version's PR, so requesting you to approve in this PR as well

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented Jun 14, 2023

    Let me know if it makes sense. This change was approved as part of our changes in preview API version.

    @amchandn Did I misunderstand the phrase? If this change was approved in preview PR, we will try to approved it in this PR. Or if not, we still think you should fix the MV error.

    Yes, this change was approved as part of preview API version's PR, so requesting you to approve in this PR as well

    I haven't found this change in preview PR, can you tag it here?

    @amchandn
    Copy link
    Copy Markdown
    Contributor

    Let me know if it makes sense. This change was approved as part of our changes in preview API version.

    @amchandn Did I misunderstand the phrase? If this change was approved in preview PR, we will try to approved it in this PR. Or if not, we still think you should fix the MV error.

    Yes, this change was approved as part of preview API version's PR, so requesting you to approve in this PR as well

    I haven't found this change in preview PR, can you tag it here?

    Hi @keryul , I recheckede and realised that as part of that PR we did not add this property in request. So this seems to be a new change in example only. Sorry for the confusion.

    @amchandn
    Copy link
    Copy Markdown
    Contributor

    Let me know if it makes sense. This change was approved as part of our changes in preview API version.

    @amchandn Did I misunderstand the phrase? If this change was approved in preview PR, we will try to approved it in this PR. Or if not, we still think you should fix the MV error.

    Yes, this change was approved as part of preview API version's PR, so requesting you to approve in this PR as well

    I haven't found this change in preview PR, can you tag it here?

    Hi @keryul , I recheckede and realised that as part of that PR we did not add this property in request. So this seems to be a new change in example only. Sorry for the confusion.

    We have removed the readonly property from request example and all required checks are passing now.

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented Jun 21, 2023

    @qiaozha please review the JS breaking change

    @ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 23, 2023
    @Shashank1306s
    Copy link
    Copy Markdown
    Contributor Author

    Hi @keryul, ARM review has been completed. Can we merge this PR if we have no more issues?

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented Jun 25, 2023

    @qiaozha please review the JS breaking change

    @kazrael2119
    Copy link
    Copy Markdown
    Member

    this js sdk breaking should be a non-breaking

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.