Add new stable API-version 2023-05-01 in Microsoft.Dataprotection#24011
Add new stable API-version 2023-05-01 in Microsoft.Dataprotection#24011rkmanda merged 10 commits intoAzure:mainfrom
Conversation
|
Hi, @Shashank1306s Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| dataprotection.json | 2023-05-01(753c9ce) | 2023-01-01(main) |
| dataprotection.json | 2023-05-01(753c9ce) | 2023-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchSecondaryRecoveryPoints' removed or restructured? Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1531:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/crossRegionRestore' removed or restructured? Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1606:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/validateCrossRegionRestore' removed or restructured? Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1684:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchCrossRegionRestoreJob' removed or restructured? Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1762:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DataProtection/locations/{location}/fetchCrossRegionRestoreJobs' removed or restructured? Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1818:5 |
|
| The new version is missing a path that was found in the old version. Was path '/{resourceId}/providers/Microsoft.DataProtection/backupInstances' removed or restructured? Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L1877:5 |
|
| The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreJobRequest' removed or renamed? New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreJobsRequest' removed or renamed? New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'FetchSecondaryRPsRequestParameters' removed or renamed? New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreDetails' removed or renamed? New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ValidateCrossRegionRestoreRequestObject' removed or renamed? New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3 |
|
| The new version is missing a definition that was found in the old version. Was 'CrossRegionRestoreRequestObject' removed or renamed? New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L3735:3 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L4123:3 |
|
| The new version is missing a client parameter that was found in the old version. Was 'ResourceId' removed or renamed? New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L7467:3 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L7912:3 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L5520:11 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5920:11 |
|
| The new version has a different format than the previous one. New: common-types/resource-management/v4/managedidentity.json#L27:9 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5932:9 |
|
| The new version has a different format than the previous one. New: common-types/resource-management/v4/managedidentity.json#L21:9 Old: Microsoft.DataProtection/preview/2023-04-01-preview/dataprotection.json#L5937:9 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2023-05 | package-2023-05(753c9ce) | default(main) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L42 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true.Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L64 |
ParametersOrder |
The parameters:operationId,location should be kept in the same order as they present in the path. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L64 |
GetOperation200 |
The get operation should only return 200. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L94 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L184 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L307 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L328 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L410 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L426 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L467 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L476 |
LroLocationHeader |
A 202 response should include an Location response header. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L526 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L532 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L544 |
LroExtension |
Operations with a 202 response must specify x-ms-long-running-operation: true.Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L545 |
GetOperation200 |
The get operation should only return 200. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L580 |
OperationsApiSchemaUsesCommonTypes |
Operations API path must follow the schema provided in the common types. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L740 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L761 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L788 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L809 |
ResourceNameRestriction |
The resource name parameter 'backupPolicyName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L809 |
PutResponseSchemaDescription |
Any Put MUST contain 200 and 201 return codes. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L899 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L969 |
GetCollectionOnlyHasValueAndNextLink |
Get endpoints for collections of resources must only have the value and nextLink properties in their model.Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L996 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1017 |
ResourceNameRestriction |
The resource name parameter 'backupInstanceName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1017 |
PutResponseSchemaDescription |
Description of 200 response code of a PUT operation MUST include term 'update'. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1099 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1128 |
LroErrorContent |
Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1193 |
ResourceNameRestriction |
The resource name parameter 'vaultName' should be defined with a 'pattern' restriction. Location: Microsoft.DataProtection/stable/2023-05-01/dataprotection.json#L1205 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 43 Errors, 0 Warnings failed [Detail]
Tag package-2023-05; Prod region: Deployed
Test run on region: westcentralus; Operation coverage: total: 66, untested: 0, failed: 43, passed: 23
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
CLIENT_ERROR |
statusCode: 400, errorCode: BMSUserErrorInvalidInput, errorMessage: The user input given for the call is invalid Source: runtime OperationId: BackupVaults_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupVaults_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupVaults_Update |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_List |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_GetBackupInstanceOperationResult |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_AdhocBackup |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/backupInstances/validateRestore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9/backupInstances/backupin7gmp2c'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/testdb' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_ValidateForRestore |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_SyncBackupInstance |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_SuspendBackups |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_StopProtection |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_ResumeBackups |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_ResumeProtection |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/backupInstances/restore/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9/backupInstances/backupin7gmp2c'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest/databases/testdb' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_TriggerRestore |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' has permission to perform action 'Microsoft.DataProtection/backupVaults/validateForBackup/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9'; however, it does not have permission to perform action 'read' on the linked scope(s) '/subscriptions/f75d8d8b-6735-4697-82e1-1a7a3ff0d5d4/resourceGroups/viveksipgtest/providers/Microsoft.DBforPostgreSQL/servers/viveksipgtest' or the linked scope(s) are invalid. Source: runtime OperationId: BackupInstances_ValidateForBackup |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupInstances_TriggerRehydrate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DppResourceGuardProxy_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DppResourceGuardProxy_List |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: DppResourceGuardProxy_Get |
CLIENT_ERROR |
statusCode: 403, errorCode: LinkedAuthorizationFailed, errorMessage: The client has permission to perform action 'Microsoft.DataProtection/resourceGuards/deleteBackupInstanceRequests/approve/action' on scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5/resourceGroups/apiTest-wDMCzE-24011/providers/Microsoft.DataProtection/backupVaults/vaultnamdvj9s9/backupResourceGuardProxies/resourceqskvjy', however the linked subscription 'f9e67185-f313-4e79-aa71-6458d429369d' was not found. Source: runtime OperationId: DppResourceGuardProxy_UnlockDelete |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupPolicies_CreateOrUpdate |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupPolicies_List |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: BackupPolicies_Get |
CLIENT_ERROR |
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.DataProtection/locations/checkFeatureSupport/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: DataProtection_CheckFeatureSupport |
CLIENT_ERROR |
statusCode: 400, errorCode: BMSUserErrorInvalidInput, errorMessage: The user input given for the call is invalid Source: runtime OperationId: OperationResult_Get |
CLIENT_ERROR |
statusCode: 400, errorCode: BMSUserErrorInvalidInput, errorMessage: The user input given for the call is invalid Source: runtime OperationId: OperationStatus_Get |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: RestorableTimeRanges_Find |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: RecoveryPoints_List |
CLIENT_ERROR |
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.DataProtection/BackupVaults/vaultnamdvj9s9' under resource group 'apiTest-wDMCzE-24011' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: RecoveryPoints_Get |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
Hi, @Shashank1306s, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
Hi, @Shashank1306s your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
Instead of defining it here, use "ManagedServiceIdentity" from common-types: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/managedidentity.json. Refers to: specification/dataprotection/resource-manager/Microsoft.DataProtection/stable/2023-05-01/dataprotection.json:4321 in 26675d4. [](commit_id = 26675d4, deletion_comment = False) |
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
Hi @visingla-ms, NamespacedNameResource is defined in common contract and it defines those resources which are identified by both namespace and its name. |
|
Here in one of the required checks: Swagger ModelValidation.. I can see failure's Customer can send this sometimes and instead of failing the call we would just ignore it.. Before finalizing this we posted this on stack overflow and this was one of the recommended way of handling such properties. |
I don't understand what you mean by
Do you mean there is no prior art of a suppression on this type of error? Or that the other PR has an exclusion within it that we can copy? |
Hi @keryul , @scbedd , looks like a force push by the PR author undoe'd the concerned change. We're making that change again and will update the conversation in this PR. |
I want to know if that PR has an exclusion within it that we can copy cause I haven't found any readOnly property in request in that PR. |
@keryul , @scbedd , here is the failing example and readonly property that is failing check during ModelValidation with examples `
|
@amchandn Did I misunderstand the phrase? If this change was approved in preview PR, we will try to approved it in this PR. Or if not, we still think you should fix the MV error. |
Yes, this change was approved as part of preview API version's PR, so requesting you to approve in this PR as well |
I haven't found this change in preview PR, can you tag it here? |
Hi @keryul , I recheckede and realised that as part of that PR we did not add this property in request. So this seems to be a new change in example only. Sorry for the confusion. |
We have removed the readonly property from request example and all required checks are passing now. |
|
@qiaozha please review the JS breaking change |
|
Hi @keryul, ARM review has been completed. Can we merge this PR if we have no more issues? |
|
@qiaozha please review the JS breaking change |
|
this js sdk breaking should be a non-breaking |
ARM API Information (Control Plane)
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.