Skip to content

Adding Application Insights Data Plane#2404

Merged
anuchandy merged 8 commits intoAzure:masterfrom
alexeldeib:ace/ai-data-plane
Feb 6, 2018
Merged

Adding Application Insights Data Plane#2404
anuchandy merged 8 commits intoAzure:masterfrom
alexeldeib:ace/ai-data-plane

Conversation

@alexeldeib
Copy link
Copy Markdown
Contributor

@alexeldeib alexeldeib commented Feb 2, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link
Copy Markdown

This commit was treated and no generation was made for Azure/azure-sdk-for-python

@AutorestCI
Copy link
Copy Markdown

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/applicationinsights/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@anuchandy
Copy link
Copy Markdown
Member

@alexeldeib thank you. Could you take a look at the model validation errors reported by CI.

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Feb 6, 2018

Automation for azure-sdk-for-python

Was unable to create SDK azure-sdk-for-python PR for this closed PR.

@AutorestCI
Copy link
Copy Markdown

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/applicationinsights/data-plane/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@alexeldeib
Copy link
Copy Markdown
Contributor Author

alexeldeib commented Feb 6, 2018

@anuchandy Sorry about that -- looks like I goofed when I ran OAV locally. I've made some adjustments. I see in the CI build jobs 8, 9 still fail but due to external issues.

@anuchandy
Copy link
Copy Markdown
Member

@alexeldeib thanks for addressing the model error, yes please ignore the jobs 8 & 9.

@anuchandy anuchandy merged commit 1b9f6f4 into Azure:master Feb 6, 2018
@AutorestCI
Copy link
Copy Markdown

This commit was treated and no generation was made for Azure/azure-sdk-for-go

@AutorestCI
Copy link
Copy Markdown

Swagger to SDK encountered an unknown error: (Azure/azure-sdk-for-go)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/github_tools.py", line 29, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 180, in rest_handle_action
    return rest_pull_close(body, github_con, restapi_repo, sdk_pr_target_repo, sdkbase)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 311, in rest_pull_close
    rest_pr.create_issue_comment("Was unable to create SDK %s PR for this closed PR.", sdkid)
TypeError: create_issue_comment() takes 2 positional arguments but 3 were given

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants