Skip to content

AppGW: Add default predefined ssl policy field in resource#24094

Merged
ArcturusZhang merged 2 commits intoAzure:release-network-Microsoft.Network-official-2023-02-01from
prateek2211:defaultPredefinedSslPolicy
Jun 1, 2023
Merged

AppGW: Add default predefined ssl policy field in resource#24094
ArcturusZhang merged 2 commits intoAzure:release-network-Microsoft.Network-official-2023-02-01from
prateek2211:defaultPredefinedSslPolicy

Conversation

@prateek2211
Copy link
Copy Markdown
Contributor

@prateek2211 prateek2211 commented May 22, 2023

ARM API Information (Control Plane)

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. 08/06
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. 08/06
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Note that this doesn't apply if you are trying to merge a PR that was previously in the private repository.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link
Copy Markdown

Hi, @prateek2211 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 22, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    compared swaggers (via Oad v0.10.4)] new version base version
    applicationGateway.json 2023-02-01(7af62de) 2022-11-01(main)
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.2) new version base version
    package-2023-02 package-2023-02(7af62de) package-2023-02(release-network-Microsoft.Network-official-2023-02-01)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L37
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L72
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L84
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L194
    PatchIdentityProperty The patch operation body parameter schema should contains property 'identity'.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L234
    ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L351
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L352
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L389
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L395
    ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L405
    LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L406
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L443
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L449
    ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L459
    ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L471
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L507
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L513
    ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L523
    ParametersInPost $expand is a query parameter. Post operation must not contain any query parameter other than api-version.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L535
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L580
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L586
    ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L596
    ResourceNameRestriction The resource name parameter 'applicationGatewayName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L649
    ResourceNameRestriction The resource name parameter 'connectionName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L649
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L691
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L703
    ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L712
    PutResponseSchemaDescription Any Put MUST contain 200 and 201 return codes.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L756
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L763
    LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
    Location: Microsoft.Network/stable/2023-02-01/applicationGateway.json#L769
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 22, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️SDK Breaking Change Tracking warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-python-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-sdk-for-java warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link
    Copy Markdown

    openapi-pipeline-app Bot commented May 22, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Swagger Microsoft.Network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Go sdk/resourcemanager/network/armnetwork Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    Java azure-resourcemanager-network-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
    JavaScript @azure/arm-network Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 22, 2023
    @ghost
    Copy link
    Copy Markdown

    ghost commented May 22, 2023

    Thank you for your contribution prateek2211! We will review the pull request and get back to you soon.

    @prateek2211
    Copy link
    Copy Markdown
    Contributor Author

    @microsoft-github-policy-service agree company="Microsoft"

    @prateek2211
    Copy link
    Copy Markdown
    Contributor Author

    @keryul Can you please review this?

    @prateek2211
    Copy link
    Copy Markdown
    Contributor Author

    @keryul Gentle ping.

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented May 31, 2023

    /azp run

    @azure-pipelines
    Copy link
    Copy Markdown

    Azure Pipelines successfully started running 1 pipeline(s).

    @ankhyk
    Copy link
    Copy Markdown
    Contributor

    ankhyk commented Jun 1, 2023

    @raych1 @msyyc @qiaozha please help take a look at GO, Python and JS SDK breaking change

    @raych1 raych1 added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jun 1, 2023
    @ankhyk ankhyk added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label Jun 1, 2023
    @ArcturusZhang ArcturusZhang merged commit 57921c5 into Azure:release-network-Microsoft.Network-official-2023-02-01 Jun 1, 2023
    msyyc pushed a commit that referenced this pull request Jun 13, 2023
    * Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Fixed double header issue (#23896)
    
    * Edited description for additional nics (#24071)
    
    * swagger 20230201 adding resource guid (#24154)
    
    * Appgw: Remove 499 status code from custom error page (#24095)
    
    * Add AdminState Property to Virtual Network Gateway Resource Properties (#23978)
    
    * add adminstate
    
    * update description
    
    * add headers to 202
    
    * prettier fix
    
    * AppGW: Add default predefined ssl policy field in resource (#24094)
    
    * Fix examples (#24274)
    
    ---------
    
    Co-authored-by: Mikhail <mitryakh@microsoft.com>
    Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com>
    Co-authored-by: sssharma24 <107450300+sssharma24@users.noreply.github.com>
    Co-authored-by: Prateek Sachan <42961174+prateek2211@users.noreply.github.com>
    Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
    Co-authored-by: Sindhu Aluguvelli <sindhureddy216@gmail.com>
    harryli0108 pushed a commit to harryli0108/azure-rest-api-specs that referenced this pull request Jul 28, 2023
    * Adds base for updating Microsoft.Network from version stable/2022-11-01 to version 2023-02-01
    
    * Updates readme
    
    * Updates API version in new specs and examples
    
    * Fixed double header issue (Azure#23896)
    
    * Edited description for additional nics (Azure#24071)
    
    * swagger 20230201 adding resource guid (Azure#24154)
    
    * Appgw: Remove 499 status code from custom error page (Azure#24095)
    
    * Add AdminState Property to Virtual Network Gateway Resource Properties (Azure#23978)
    
    * add adminstate
    
    * update description
    
    * add headers to 202
    
    * prettier fix
    
    * AppGW: Add default predefined ssl policy field in resource (Azure#24094)
    
    * Fix examples (Azure#24274)
    
    ---------
    
    Co-authored-by: Mikhail <mitryakh@microsoft.com>
    Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com>
    Co-authored-by: sssharma24 <107450300+sssharma24@users.noreply.github.com>
    Co-authored-by: Prateek Sachan <42961174+prateek2211@users.noreply.github.com>
    Co-authored-by: nimaller <71352534+nimaller@users.noreply.github.com>
    Co-authored-by: Sindhu Aluguvelli <sindhureddy216@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python CI-BreakingChange-Go CI-BreakingChange-JavaScript customer-reported Issues that are reported by GitHub users external to the Azure organization. Network resource-manager

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    7 participants