Skip to content

Minor updates to ADL specs#253

Merged
amarzavery merged 23 commits intoAzure:masterfrom
begoldsm:master
Apr 20, 2016
Merged

Minor updates to ADL specs#253
amarzavery merged 23 commits intoAzure:masterfrom
begoldsm:master

Conversation

@begoldsm
Copy link
Copy Markdown
Contributor

This set of changes has already been merged as the SDK pieces for node and .NET. Here are the changes:

  1. remove subscription ID from specs that don't need it.
  2. rename "Type" to "JobResourceType" to avoid collisions.
  3. Remove modeling as string as it was unnecessary and made coding against more difficult.
  4. Add a new api version for job APIs which enables proper ISO formatting for date time and duration.
  5. Adding transfer-encoding values to headers for our PUT/PATCH requests that need it. This is a work around for issue: All Stream request body APIs should use Transfer-Encoding:chunked autorest#903
  6. Re-add MSLISTSTATUS now that it is back in the front end.

begoldsm added 22 commits March 24, 2016 13:32
These clients don't need a subscriptionId.
Will add extensions that make it optional in C# and zero it out to an
empty stream.
Issue: Azure/autorest#884 is tracking support
for this being an optional param properly and not resulting in a null
reference. So I will keep this spec as is.
Makes this more obvious to end users and easier to understand.
This API version changes the format for dates and timespan objects to be
ISO compliant.
We need a way to have template parameters not be required when they are
in the host. I will work with Amar for this next week.
Switch over to MSLISTSTATUS which gives more flexibility for listing
files/folders.
explicitly calling out our chunked transfer APIs until issue:
Azure/autorest#903 is resolved.
}
},
"x-ms-parameterized-host": {
"hostTemplate": "{accountName}.{adlaJobDnsSuffix}",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accountName will be added in the beginning by default. Please specify the positionInOperation: last.

Take a look at the documentation over here: https://github.com/Azure/autorest/blob/master/Documentation/swagger-extensions.md#x-ms-parameterized-host

I think, when the extension was designed initially, it was adding the path parameter in the end. Hence, when the extension was updated, datalake specs were updated accordingly. This seems like a new spec.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that, and we made the (painful) decision to take advantage of your change and move accountName back to the front, since it is much more consistent and in line with what we had in Hyak land. If it makes it more explicit, I can include the positionInOperation: first tag, if you like?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first is default. So you are good for now.

@amarzavery amarzavery merged commit 706cb8f into Azure:master Apr 20, 2016
"in": "query",
"required": false,
"type": "string",
"description": "The return format. Return the response in particular formatxii without access to request headers for standard content-type negotiation (e.g Orders?$format=json). Optional."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@begoldsm - formatxii. Make the change in your fork, so next time when you send the PR its fixed. Or may be send one; upto you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants