Swagger Correctness missing Cache property by sampathvasalav · Pull Request #26701 · Azure/azure-rest-api-specs

sampathvasalav · 2023-11-14T12:18:49Z

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix swagger quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
- The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
- You believe there is no need for you to request breaking change approval, for any reason.
  Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Missing Cache property

Missing cache property stable version

openapi-pipeline-app · 2023-11-14T12:18:53Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

openapi-pipeline-app · 2023-11-14T12:18:54Z

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
bigDataPool.json	2021-06-01-preview(2d1eb92)	2021-06-01-preview(main)
bigDataPool.json	2021-06-01(2d1eb92)	2021-06-01(main)

Rule	Message
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L433:9 Old: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L433:9
`❌` 1029 - ReadonlyPropertyChanged	The read only property has changed from 'true' to 'false'. New: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L433:9 Old: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L433:9

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️❌LintDiff: 6 Errors, 0 Warnings failed [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2021-06	package-2021-06(2d1eb92)	package-2021-06(main)
package-preview-2021-06	package-preview-2021-06(2d1eb92)	package-preview-2021-06(main)
package-composite-v2	package-composite-v2(2d1eb92)	package-composite-v2(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/privateEndpointConnections.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/2d1eb92191feacee63079842982e3dfb3231f57a/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/privatelinkhub.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/2d1eb92191feacee63079842982e3dfb3231f57a/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/privateEndpointConnections.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/2d1eb92191feacee63079842982e3dfb3231f57a/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/preview/2021-06-01-preview/privatelinkhub.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/2d1eb92191feacee63079842982e3dfb3231f57a/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/privateEndpointConnections.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/2d1eb92191feacee63079842982e3dfb3231f57a/#L1
`❌` FATAL	spectralPluginFunc: Failed validating: 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/synapse/resource-manager/Microsoft.Synapse/stable/2021-06-01/privatelinkhub.json'. Errors encountered: Error: Error running Nimma Error 1: $[paths,'x-ms-paths'] threw: ErrorWithCause('Function 'ParametersInPointGet' threw an exception: Cannot read property 'filter' of undefined') Location: azure-rest-api-specs/blob/2d1eb92191feacee63079842982e3dfb3231f57a/#L1

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L24
`❌` ResourceNameRestriction	The resource name parameter 'bigDataPoolName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L24
`❌` ResourceNameRestriction	The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L24
`❌` ResourceNameRestriction	The resource name parameter 'bigDataPoolName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L24
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L142
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L142
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L142
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L142
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L195
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L195
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L224
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L224
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L255
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L255
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L260
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L260
`❌` ResourceNameRestriction	The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L291
`❌` ResourceNameRestriction	The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L291
`❌` ResourceNameRestriction	The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L24
`❌` ResourceNameRestriction	The resource name parameter 'bigDataPoolName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L24
`❌` ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L142
`❌` PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L142
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L195
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L224
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L255
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L260
`❌` ResourceNameRestriction	The resource name parameter 'workspaceName' should be defined with a 'pattern' restriction. Location: Microsoft.Synapse/stable/2021-06-01/bigDataPool.json#L291
⚠️ PreviewVersionOverOneYear	The API version:2021-06-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L4
⚠️ PreviewVersionOverOneYear	The API version:2021-06-01-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L4
⚠️ RequiredReadOnlySystemData	The response of operation:'BigDataPools_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Synapse/preview/2021-06-01-preview/bigDataPool.json#L25

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/synapse/resource-manager/readme.md tag: specification/synapse/resource-manager/readme.md#tag-package-composite-v2

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️⌛Automated merging requirements met pending [Detail]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-14T12:18:55Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go - sdk/resourcemanager/synapse/armsynapse - Approved - 0.9.0

+	Function `*SQLPoolsClient.Rename` has been removed
+	Struct `ResourceMoveDefinition` has been removed

❌azure-sdk-for-js - @azure/arm-synapse - Approved - 9.0.0-beta.2

+	Class SynapseManagementClient has a new signature
+	Class SynapseManagementClient no longer has parameter privateLinkResources
+	Interface IntegrationRuntimeStatusResponse has a new required parameter type
+	Interface IntegrationRuntimeStatusResponse no longer has parameter properties
+	Interface SqlPoolSchemasListNextOptionalParams no longer has parameter filter
+	Interface SqlPoolSensitivityLabelsListCurrentNextOptionalParams no longer has parameter filter
+	Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter filter
+	Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter includeDisabledRecommendations
+	Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter skipToken
+	Interface SqlPoolTableColumnsListByTableNameNextOptionalParams no longer has parameter filter
+	Interface SqlPoolTablesListBySchemaNextOptionalParams no longer has parameter filter
+	Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
+	Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState
+	Removed operation SqlPoolOperationResults.getLocationHeaderResult
+	Removed operation SqlPools.rename
+	Removed operation SqlPools.update
+	Removed operation group PrivateLinkResources
+	Type of parameter actualState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState to ActualState
+	Type of parameter desiredState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState to DesiredState

❌azure-sdk-for-python-track2 - track2_azure-mgmt-synapse - Approved - 2.1.0b7

+	Removed operation SqlPoolsOperations.rename

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from f81cf2377daea781f6a1e74d47c5678060d99e5e. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cannot force update branch 'sdkAuto/26701/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/26701/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.

️✔️Azure.ResourceManager.Synapse [View full logs] [Preview SDK Changes]
- Azure.ResourceManager.Synapse.1.3.0-alpha.20231206.1.nupkg
```
info	[Changelog]
```

️✔️Azure.ResourceManager.Synapse [View full logs] Breaking Change Detected

error	Fatal error: cannot force update branch 'sdkAuto/26701/Azure.ResourceManager.Synapse' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		Azure.ResourceManager.Synapse
error		Azure.ResourceManager.Synapse

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from f81cf2377daea781f6a1e74d47c5678060d99e5e. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-synapse [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-synapse-9.0.0-beta.2.tgz

Only show 120 items here, please refer to log for details.

info	[Changelog]   - Added Interface EventGridDataConnection
info	[Changelog]   - Added Interface EventHubDataConnection
info	[Changelog]   - Added Interface ExtendedServerBlobAuditingPolicy
info	[Changelog]   - Added Interface ExtendedSqlPoolBlobAuditingPolicy
info	[Changelog]   - Added Interface GeoBackupPolicy
info	[Changelog]   - Added Interface GetIntegrationRuntimeEnableInteractivequeryOptionalParams
info	[Changelog]   - Added Interface GetIntegrationRuntimeStartOptionalParams
info	[Changelog]   - Added Interface GetIntegrationRuntimeStopOptionalParams
info	[Changelog]   - Added Interface IntegrationRuntimeEnableinteractivequery
info	[Changelog]   - Added Interface IntegrationRuntimeOperationStatus
info	[Changelog]   - Added Interface IntegrationRuntimeResource
info	[Changelog]   - Added Interface IntegrationRuntimeStopOperationStatus
info	[Changelog]   - Added Interface IotHubDataConnection
info	[Changelog]   - Added Interface IpFirewallRuleInfo
info	[Changelog]   - Added Interface Key
info	[Changelog]   - Added Interface KustoPool
info	[Changelog]   - Added Interface KustoPoolPrivateLinkResources
info	[Changelog]   - Added Interface KustoPoolPrivateLinkResourcesListOptionalParams
info	[Changelog]   - Added Interface KustoPoolUpdate
info	[Changelog]   - Added Interface LibraryResource
info	[Changelog]   - Added Interface LinkedIntegrationRuntimeKeyAuthorization
info	[Changelog]   - Added Interface LinkedIntegrationRuntimeRbacAuthorization
info	[Changelog]   - Added Interface MaintenanceWindowOptions
info	[Changelog]   - Added Interface MaintenanceWindows
info	[Changelog]   - Added Interface ManagedIdentitySqlControlSettingsModel
info	[Changelog]   - Added Interface ManagedIntegrationRuntime
info	[Changelog]   - Added Interface ManagedIntegrationRuntimeStatus
info	[Changelog]   - Added Interface MetadataSyncConfig
info	[Changelog]   - Added Interface PrivateEndpointConnection
info	[Changelog]   - Added Interface PrivateEndpointConnectionForPrivateLinkHub
info	[Changelog]   - Added Interface PrivateLinkHub
info	[Changelog]   - Added Interface PrivateLinkResource
info	[Changelog]   - Added Interface PrivateLinkResources
info	[Changelog]   - Added Interface ProxyResource
info	[Changelog]   - Added Interface ReadOnlyFollowingDatabase
info	[Changelog]   - Added Interface ReadWriteDatabase
info	[Changelog]   - Added Interface RecommendedSensitivityLabelUpdate
info	[Changelog]   - Added Interface RecoverableSqlPool
info	[Changelog]   - Added Interface ReplicationLink
info	[Changelog]   - Added Interface RestorableDroppedSqlPool
info	[Changelog]   - Added Interface RestorePoint
info	[Changelog]   - Added Interface SecureString
info	[Changelog]   - Added Interface SelfHostedIntegrationRuntime
info	[Changelog]   - Added Interface SelfHostedIntegrationRuntimeStatus
info	[Changelog]   - Added Interface SensitivityLabel
info	[Changelog]   - Added Interface SensitivityLabelUpdate
info	[Changelog]   - Added Interface ServerBlobAuditingPolicy
info	[Changelog]   - Added Interface ServerSecurityAlertPolicy
info	[Changelog]   - Added Interface ServerVulnerabilityAssessment
info	[Changelog]   - Added Interface SparkConfigurationResource
info	[Changelog]   - Added Interface SqlPool
info	[Changelog]   - Added Interface SqlPoolBlobAuditingPolicy
info	[Changelog]   - Added Interface SqlPoolColumn
info	[Changelog]   - Added Interface SqlPoolConnectionPolicy
info	[Changelog]   - Added Interface SqlPoolOperation
info	[Changelog]   - Added Interface SqlPoolSchema
info	[Changelog]   - Added Interface SqlPoolSecurityAlertPolicy
info	[Changelog]   - Added Interface SqlPoolTable
info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessment
info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentRuleBaseline
info	[Changelog]   - Added Interface SqlPoolVulnerabilityAssessmentScansExport
info	[Changelog]   - Added Interface SsisEnvironment
info	[Changelog]   - Added Interface SsisFolder
info	[Changelog]   - Added Interface SsisPackage
info	[Changelog]   - Added Interface SsisProject
info	[Changelog]   - Added Interface SubResource
info	[Changelog]   - Added Interface TrackedResource
info	[Changelog]   - Added Interface TransparentDataEncryption
info	[Changelog]   - Added Interface VulnerabilityAssessmentScanRecord
info	[Changelog]   - Added Interface WorkloadClassifier
info	[Changelog]   - Added Interface WorkloadGroup
info	[Changelog]   - Added Interface Workspace
info	[Changelog]   - Added Interface WorkspaceAadAdminInfo
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetOptionalParams
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextOptionalParams
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListOptionalParams
info	[Changelog]   - Added Interface WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateOptionalParams
info	[Changelog]   - Added Type Alias ActualState
info	[Changelog]   - Added Type Alias DedicatedSQLMinimalTlsSettingsName
info	[Changelog]   - Added Type Alias DesiredState
info	[Changelog]   - Added Type Alias GetIntegrationRuntimeEnableInteractivequeryResponse
info	[Changelog]   - Added Type Alias GetIntegrationRuntimeStartResponse
info	[Changelog]   - Added Type Alias GetIntegrationRuntimeStopResponse
info	[Changelog]   - Added Type Alias KustoPoolPrivateLinkResourcesListResponse
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsGetResponse
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListNextResponse
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsListResponse
info	[Changelog]   - Added Type Alias WorkspaceManagedSqlServerDedicatedSQLMinimalTlsSettingsUpdateResponse
info	[Changelog]   - Added Type Alias WorkspaceStatus
info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new optional parameter dataFactoryName
info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new optional parameter state
info	[Changelog]   - Interface SqlPoolOperationResultsGetLocationHeaderResultOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface SqlPoolOperationResultsGetLocationHeaderResultOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface SqlPoolsUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface SqlPoolsUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Added Enum KnownDedicatedSQLMinimalTlsSettingsName
info	[Changelog]   - Added Enum KnownWorkspaceStatus
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation group PrivateLinkResources
info	[Changelog]   - Removed operation SqlPoolOperationResults.getLocationHeaderResult
info	[Changelog]   - Removed operation SqlPools.rename
info	[Changelog]   - Removed operation SqlPools.update
info	[Changelog]   - Class SynapseManagementClient has a new signature
info	[Changelog]   - Interface IntegrationRuntimeStatusResponse no longer has parameter properties
info	[Changelog]   - Interface SqlPoolSchemasListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface SqlPoolSensitivityLabelsListCurrentNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter includeDisabledRecommendations
info	[Changelog]   - Interface SqlPoolSensitivityLabelsListRecommendedNextOptionalParams no longer has parameter skipToken
info	[Changelog]   - Interface SqlPoolTableColumnsListByTableNameNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface SqlPoolTablesListBySchemaNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface IntegrationRuntimeStatusResponse has a new required parameter type
info	[Changelog]   - Type of parameter actualState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState to ActualState
info	[Changelog]   - Type of parameter desiredState of interface ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentity is changed from ManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState to DesiredState
info	[Changelog]   - Class SynapseManagementClient no longer has parameter privateLinkResources
info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityActualState
info	[Changelog]   - Removed Enum KnownManagedIdentitySqlControlSettingsModelPropertiesGrantSqlControlToManagedIdentityDesiredState

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from f81cf2377daea781f6a1e74d47c5678060d99e5e. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-synapse [View full logs] [Preview SDK Changes]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from f81cf2377daea781f6a1e74d47c5678060d99e5e. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@10.2.4` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-synapse [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter os_type
info	[Changelog]   - Model SelfHostedIntegrationRuntimeStatus has a new parameter target_framework
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Removed operation SqlPoolsOperations.rename

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from f81cf2377daea781f6a1e74d47c5678060d99e5e. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/synapse/armsynapse [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*SQLPoolsClient.Rename` has been removed
info	[Changelog] - Struct `ResourceMoveDefinition` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - Type of `WorkspaceProperties.ExtraProperties` has been changed from `map[string]any` to `any`
info	[Changelog] - New field `OSType`, `TargetFramework` in struct `SelfHostedIntegrationRuntimeStatusTypeProperties`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 1 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from f81cf2377daea781f6a1e74d47c5678060d99e5e. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.4
cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.4>
cmderr	[initScript.sh] npm notice Run `npm install -g npm@10.2.4` to update!
cmderr	[initScript.sh] npm notice
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️synapse [View full logs] [Preview Schema Changes]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from f81cf2377daea781f6a1e74d47c5678060d99e5e. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

⚠️Az.synapse.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.synapse.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-14T12:18:56Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/synapse/armsynapse	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-synapse	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-synapse	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
.Net	Azure.ResourceManager.Synapse	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger	Microsoft.Synapse	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2023-11-14T12:26:44Z

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

sampathvasalav · 2023-11-29T04:59:58Z

Please fix the model validation failures and request a merge after that check is passing

@rkmanda, the model validation failures are not caused by my changes. Those changes are coming from main. Could you pls take this forward.

rkmanda · 2023-11-29T23:25:13Z

Model validation failures will be fixed with the next PR

rkmanda · 2023-11-29T23:29:52Z

/azp run

azure-pipelines · 2023-11-29T23:30:07Z

Azure Pipelines successfully started running 3 pipeline(s).

sampathvasalav · 2023-12-05T03:59:56Z

@rkmanda can you pls merge this PR. All the required checks are done from my side. Customer is waiting for this fix.

sampathvasalav · 2023-12-05T04:04:29Z

/pr RequestMerge

visingla-ms · 2023-12-05T13:31:56Z

/azp run

azure-pipelines · 2023-12-05T13:32:14Z

Azure Pipelines successfully started running 3 pipeline(s).

sampathvasalav · 2023-12-06T12:51:04Z

@rkmanda, Can you please merge this ASAP.

visingla-ms · 2023-12-06T19:33:14Z

/azp run

azure-pipelines · 2023-12-06T19:33:30Z

Azure Pipelines successfully started running 3 pipeline(s).

konrad-jamrozik · 2023-12-06T20:14:30Z

This PR checks are stuck because license/cla is stuck.

I am going to follow guidance linked from the check that says:
https://github.com/microsoft/contributorlicenseagreement#re-running

And post:
@microsoft-github-policy-service rerun

Note I also found general getting help guidance here:
https://eng.ms/docs/more/github-inside-microsoft/overview/questions

konrad-jamrozik · 2023-12-06T20:14:38Z

@microsoft-github-policy-service rerun

konrad-jamrozik · 2023-12-06T20:15:38Z

@microsoft-github-policy-service agree

konrad-jamrozik · 2023-12-06T20:18:32Z

@sampathvasalav to unblock this PR, can you reply with a comment like this one?
#26701 (comment)

For context, please see:

visingla-ms · 2023-12-06T21:17:35Z

Please move the PR for merging once handled the licensing.

sampathvasalav · 2023-12-07T01:30:07Z

@microsoft-github-policy-service agree

sampathvasalav · 2023-12-07T01:30:48Z

@microsoft-github-policy-service rerun

sampathvasalav · 2023-12-07T01:35:34Z

/pr RequestMerge

sampathvasalav added 2 commits November 14, 2023 17:12

Update bigDataPool.json

6e2de6e

Missing Cache property

Update bigDataPool.json

2d1eb92

Missing cache property stable version

sampathvasalav requested review from wonner and yanjungao718 as code owners November 14, 2023 12:18

openapi-assignment-bot Bot assigned rkmanda Nov 14, 2023

microsoft-github-policy-service Bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 14, 2023

azure-sdk mentioned this pull request Nov 14, 2023

[AutoPR sdk/resourcemanager/synapse/armsynapse] Swagger Correctness missing Cache property azure-sdk/azure-sdk-for-go#8223

Closed

openapi-pipeline-app Bot added the CI-BreakingChange-Go label Nov 14, 2023

AzureRestAPISpecReview added ARMChangesRequested ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required resource-manager labels Nov 14, 2023

This was referenced Nov 14, 2023

[AutoPR synapse] Swagger Correctness missing Cache property azure-sdk/azure-resource-manager-schemas#3650

Draft

[AutoPR @azure/arm-synapse] Swagger Correctness missing Cache property azure-sdk/azure-sdk-for-js#7661

Closed

openapi-pipeline-app Bot added the CI-BreakingChange-JavaScript label Nov 14, 2023

azure-sdk mentioned this pull request Nov 14, 2023

[AutoPR track2_azure-mgmt-synapse] Swagger Correctness missing Cache property azure-sdk/azure-sdk-for-python#5377

Closed

openapi-pipeline-app Bot added the CI-BreakingChange-Python-Track2 label Nov 14, 2023

This was referenced Nov 14, 2023

[AutoPR azure-resourcemanager-synapse] Swagger Correctness missing Cache property azure-sdk/azure-sdk-for-java#8492

Closed

[AutoPR Azure.ResourceManager.Synapse] Swagger Correctness missing Cache property azure-sdk/azure-sdk-for-net#6214

Closed

bansalaseem approved these changes Nov 15, 2023

View reviewed changes

bansalaseem added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 15, 2023

openapi-workflow-bot Bot removed the ARMChangesRequested label Nov 15, 2023

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Nov 15, 2023

Alancere added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Nov 16, 2023

kazrael2119 added the Approved-SdkBreakingChange-JavaScript label Nov 16, 2023

rkmanda removed the MergeRequested label Nov 28, 2023

rkmanda added the Approved-ModelValidation label Nov 29, 2023

rkmanda approved these changes Nov 29, 2023

View reviewed changes

openapi-pipeline-app Bot added MergeRequested and removed MergeRequested labels Nov 29, 2023

microsoft-github-policy-service Bot added the MergeRequested label Dec 5, 2023

visingla-ms approved these changes Dec 6, 2023

View reviewed changes

visingla-ms removed the MergeRequested label Dec 6, 2023

microsoft-github-policy-service Bot added the MergeRequested label Dec 7, 2023

visingla-ms approved these changes Dec 7, 2023

View reviewed changes

visingla-ms merged commit 583e15c into Azure:main Dec 7, 2023

Conversation

sampathvasalav commented Nov 14, 2023 • edited by openapi-workflow-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Breaking changes review (Step 1)

ARM API changes review (Step 2)

Viewing API changes

Suppressing failures

Getting help

Uh oh!

openapi-pipeline-app Bot commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app Bot commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app Bot commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot Bot commented Nov 14, 2023

Uh oh!

sampathvasalav commented Nov 29, 2023

Uh oh!

rkmanda commented Nov 29, 2023

Uh oh!

rkmanda commented Nov 29, 2023

Uh oh!

azure-pipelines Bot commented Nov 29, 2023

Uh oh!

sampathvasalav commented Dec 5, 2023

Uh oh!

sampathvasalav commented Dec 5, 2023

Uh oh!

visingla-ms commented Dec 5, 2023

Uh oh!

azure-pipelines Bot commented Dec 5, 2023

Uh oh!

sampathvasalav commented Dec 6, 2023

Uh oh!

visingla-ms commented Dec 6, 2023

Uh oh!

azure-pipelines Bot commented Dec 6, 2023

Uh oh!

konrad-jamrozik commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

konrad-jamrozik commented Dec 6, 2023

Uh oh!

konrad-jamrozik commented Dec 6, 2023

Uh oh!

konrad-jamrozik commented Dec 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

visingla-ms commented Dec 6, 2023

Uh oh!

sampathvasalav commented Dec 7, 2023

Uh oh!

sampathvasalav commented Dec 7, 2023

Uh oh!

sampathvasalav commented Dec 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

sampathvasalav commented Nov 14, 2023 •

edited by openapi-workflow-bot Bot

Loading

openapi-pipeline-app Bot commented Nov 14, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 14, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 14, 2023 •

edited

Loading

openapi-pipeline-app Bot commented Nov 14, 2023 •

edited

Loading

konrad-jamrozik commented Dec 6, 2023 •

edited

Loading

konrad-jamrozik commented Dec 6, 2023 •

edited

Loading