[TypeSpec] Upgrade azure-core and autorest to 0.37.1#27037
Merged
mikeharder merged 2 commits intoAzure:mainfrom Dec 11, 2023
Merged
[TypeSpec] Upgrade azure-core and autorest to 0.37.1#27037mikeharder merged 2 commits intoAzure:mainfrom
mikeharder merged 2 commits intoAzure:mainfrom
Conversation
mikeharder
requested review from
konrad-jamrozik,
weshaggard and
yangyuan
as code owners
Next Steps to Merge✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM). |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/1366ad7575f899972a2e8f1e1d438e6fa36a5e36/specification/cognitiveservices/data-plane/HealthInsights/preview/2023-03-01-preview/openapi.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/data-plane/HealthInsights/preview/2023-03-01-preview/openapi.json", "details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 6 lines of stack trace follow, indexed. First line should contain AutoRest command line invocation details. Second line should contain the main message reported by AutoRest. ==================== 1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.66/common/temp/node_modules/.pnpm/@Azure+oad@0.10.4/node_modules/autorest/dist/app.js" --v2 --input-file=/mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/cognitiveservices/data-plane/HealthInsights/preview/2023-03-01-preview/openapi.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=old --output-folder=/tmp -------------------- 2: ERROR: Schema violation: Data does not match any schemas from 'oneOf' -------------------- 3: - file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/cognitiveservices/data-plane/HealthInsights/preview/2023-03-01-preview/openapi.json:221:10 ($.paths["/trialmatcher/jobs"].post.responses["202"]) -------------------- 4: ERROR: Schema violation: Data does not match any schemas from 'oneOf' -------------------- 5: - file:///mnt/vss/_work/1/same-version-c93b354fd9c14905bb574a8834c4d69b/specification/cognitiveservices/data-plane/HealthInsights/preview/2023-03-01-preview/openapi.json:92:10 ($.paths["/oncophenotype/jobs"].post.responses["202"]) -------------------- 6: FATAL: swagger-document/individual/schema-validator - FAILED --------------------" |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.6) | new version | base version |
|---|---|---|
| 2023-03-01-preview | 2023-03-01-preview(1366ad7) | 2023-03-01-preview(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| Security definition should have a description. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L43 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L58 |
|
| header parameter name 'Repeatability-Request-ID' should be kebab case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L70 |
|
| Parameter should have a description. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L76 |
|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L164 |
|
| A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L200 |
|
| header parameter name 'Repeatability-Request-ID' should be kebab case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L212 |
|
| Parameter should have a description. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L218 |
|
| Path parameter should specify a maximum length (maxLength) and characters allowed (pattern). Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L306 |
|
| Schema should have a description or title. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L404 |
|
| Schema name should be Pascal case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L463 |
|
| Schema name should be Pascal case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L497 |
|
| Schema name should be Pascal case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L510 |
|
| Schema name should be Pascal case. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L524 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1515 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1520 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1532 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1865 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HealthInsights/preview/2023-03-01-preview/openapi.json#L1870 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Following response status codes 200 for operation OncoPhenotype_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L86:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulOncoPhenotypeRequest.json#L52:16 |
|
Following response status codes 200 for operation TrialMatcher_CreateJob were present in the swagger spec, however they were not present in x-ms-examples. Please provide them. Url: HealthInsights/preview/2023-03-01-preview/openapi.json#L228:18 ExampleUrl: preview/2023-03-01-preview/examples/SuccessfulTrialMatcherRequest.json#L149:16 |
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
timotheeguerin
approved these changes
Dec 11, 2023
mikeharder
added
Approved-BreakingChange
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
arifibrahim4
pushed a commit
that referenced
this pull request
Feb 26, 2024
- [HealthInsights] Update generated swagger for x-ms-enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.