[WIP] Microsoft.Web, New API 2024 01 01#27055
Closed
Francisco-Gamino wants to merge 6 commits intomainfrom
Closed
Conversation
Member
|
/azp run |
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| AppServiceEnvironments.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| AppServicePlans.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| Certificates.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| CommonDefinitions.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| ContainerApps.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| ContainerAppsRevisions.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| DeletedWebApps.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| Diagnostics.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| Global.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| KubeEnvironments.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| Provider.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| Recommendations.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| ResourceHealthMetadata.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| ResourceProvider.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| StaticSites.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
| WebApps.json | 2024-01-01(fffa0c9) | 2023-01-01(main) |
The following breaking changes are detected by comparison with the latest stable version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄LintDiff inProgress [Detail]
️❌Avocado: 32 Errors, 0 Warnings failed [Detail]
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The example JSON file is not referenced from the swagger file. readme: specification/web/resource-manager/readme.md json: stable/2024-01-01/examples/CreateOrUpdateWebApp2.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.CertificateRegistration/certificateOrders is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.CertificateRegistration/validateCertificateRegistrationInformation is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/certificates is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/certificates/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/reissue is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/renew is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/resendEmail is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/resendRequestEmails is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/retrieveSiteSeal is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/verifyDomainOwnership is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/retrieveCertificateActions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/retrieveEmailHistory is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/AppServiceCertificateOrders.json |
|
The default tag should contain all APIs. The API path /providers/Microsoft.CertificateRegistration/operations is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/CertificateRegistrationProvider.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/detectors is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/CertificateOrdersDiagnostics.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.CertificateRegistration/certificateOrders/{}/detectors/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.CertificateRegistration/stable/2023-01-01/CertificateOrdersDiagnostics.json |
|
The default tag should contain all APIs. The API path /providers/Microsoft.DomainRegistration/operations is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/DomainRegistrationProvider.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.DomainRegistration/checkDomainAvailability is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.DomainRegistration/domains is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.DomainRegistration/generateSsoRequest is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.DomainRegistration/listDomainRecommendations is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DomainRegistration/domains is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DomainRegistration/domains/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DomainRegistration/domains/{}/domainOwnershipIdentifiers is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DomainRegistration/domains/{}/domainOwnershipIdentifiers/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.DomainRegistration/domains/{}/renew is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/Domains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.DomainRegistration/topLevelDomains is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/TopLevelDomains.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.DomainRegistration/topLevelDomains/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/web/resource-manager/readme.md json: Microsoft.DomainRegistration/stable/2023-01-01/TopLevelDomains.json |
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @Francisco-Gamino! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. |
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
Contributor
Author
|
This PR is replaced by #27358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR Description
This PR contains the following changes:
2023-01-01API version)functionAppConfigdefinitionCreateOrUpdateWebApp2.jsonexample (this is a copy ofCreateOrUpdateWebApp.jsonwith the new addedfunctionAppConfigsection)PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)
ARMReviewlabel.Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.