Update `securityPostureReference` in VMScaleSet API by martinezdylan · Pull Request #28891 · Azure/azure-rest-api-specs

martinezdylan · 2024-04-29T16:24:47Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

openapi-pipeline-app · 2024-04-29T16:24:51Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-04-29T16:24:51Z

Swagger Validation Report

️❌BreakingChange: 14 Errors, 1 Warnings failed [Detail]

Compared specs (v0.10.9)	new version	base version
virtualMachineScaleSet.json	2024-03-01(8434bfb)	2024-03-01(main)

Rule	Message
`❌` 1017 - ReferenceRedirection	The '$ref' property points to different models in the old and new versions. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6347:11 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6343:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6340:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6336:7
`❌` 1026 - TypeChanged	The new version has a different type 'string' than the previous one ''. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6347:11 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6343:11
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'properties' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'location' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'id' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'name' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'type' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'tags' renamed or removed? Old: ComputeRP/stable/2024-03-01/virtualMachine.json#L2176:7
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'id' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5182:9 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5182:9
`❌` 1034 - AddedRequiredProperty	The new version has new required property 'id' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6338:5 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6334:5
`❌` 1041 - AddedPropertyInResponse	The new version has a new property 'isOverridable' in response that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6340:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6336:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'securityPostureReference' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5196:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L5196:7
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'isOverridable' that was not found in the old version. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6340:7 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6336:7
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6347:11 Old: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6343:11

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-2024-03-01	package-2024-03-01(8434bfb)	package-2024-03-01(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6352
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L6376

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L297
`❌` LroPatch202	The async patch operation should return 202. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L350
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L374
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L413
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L439
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L506
`❌` ParametersInPost	hibernate is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L512
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L554
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L576
`❌` ParametersInPost	forceDeletion is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L582
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L624
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L646
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L677
`❌` PatchResponseCodes	Long-running PATCH operations must have responses with 200, 202 and default return codes. They also must not have other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L822
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:secretUrl. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L854
`❌` PatchBodyParametersSchema	Properties of a PATCH request body must not be required, property:sourceVault. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L854
`❌` LroPatch202	The async patch operation should return 202. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L866
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L896
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L935
`❌` ParametersInPointGet	Query parameter $expand should be removed. Point Get's MUST not have query parameters other than api version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L964
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1235
`❌` ParametersInPost	skipShutdown is a query parameter. Post operation must not contain any query parameter other than api-version. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1241
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1284
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1306
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1347
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1369
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1410
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1432
`❌` PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1494
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: ComputeRP/stable/2024-03-01/virtualMachineScaleSet.json#L1535

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2024-03-01

️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-29T16:24:52Z

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]

️⚠️ azure-sdk-for-net-track2 warning [Detail]

⚠️Warning in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  807 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] GeneratePackage: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  714 |          GeneratePackage -projectFolder $projectFolder -sdkRootPath $s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Failed to generate sdk artifact

️✔️Azure.ResourceManager.Compute [Preview SDK Changes] Breaking Change Detected

info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Compute/Debug/netstandard2.0/Azure.ResourceManager.Compute.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/compute/Azure.ResourceManager.Compute/src/Azure.ResourceManager.Compute.csproj::TargetFramework=netstandard2.0]

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-compute [Preview SDK Changes] Breaking Change Detected

azure-mgmt-compute-31.0.0.zip
azure_mgmt_compute-31.0.0-py3-none-any.whl

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model SecurityPostureReference has a new parameter is_overridable
info	[Changelog]   - Model VirtualMachineScaleSetUpdateVMProfile has a new parameter security_posture_reference
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Parameter id of model SecurityPostureReference is now required

Present SDK breaking changes suppressions
Parameter id of model SecurityPostureReference is now required

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-compute-generated [Preview SDK Changes]
- pom.xml
- azure-resourcemanager-compute-generated-1.0.0-beta.1-sources.jar
- azure-resourcemanager-compute-generated-1.0.0-beta.1.jar

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-compute [Preview SDK Changes] Breaking Change Detected

azure-arm-compute-22.0.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface SecurityPostureReferenceUpdate
info	[Changelog]   - Interface SecurityPostureReference has a new optional parameter isOverridable
info	[Changelog]   - Interface VirtualMachineScaleSetUpdateVMProfile has a new optional parameter securityPostureReference
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Parameter id of interface SecurityPostureReference is now required
info	[Changelog]   - Type of parameter excludeExtensions of interface SecurityPostureReference is changed from VirtualMachineExtension[] to string[]

Present SDK breaking changes suppressions
Parameter id of interface SecurityPostureReference is now required
Type of parameter excludeExtensions of interface SecurityPostureReference is changed from VirtualMachineExtension[] to string[]

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/compute/armcompute [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string`
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New struct `SecurityPostureReferenceUpdate`
info	[Changelog] - New field `IsOverridable` in struct `SecurityPostureReference`
info	[Changelog] - New field `SecurityPostureReference` in struct `VirtualMachineScaleSetUpdateVMProfile`
info	[Changelog]
info	[Changelog] Total 1 breaking change(s), 4 additive change(s).

Present SDK breaking changes suppressions
Type of `SecurityPostureReference.ExcludeExtensions` has been changed from `[]*VirtualMachineExtension` to `[]*string`

Please refer to https://aka.ms/azsdk/sdk-suppression for more information.

️❌ azure-resource-manager-schemas failed [Detail]

❌Code Generator Failed in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

️❌ azure-powershell failed [Detail]

❌Code Generator Failed in generating from 77cc3bd5d15f8e3b1577c1ac319dc8bc63cdf77d. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
error	Script return with result [failed] code [2] signal [null] cwd [azure-powershell]: sh ./tools/SwaggerCI/init.sh
warn	File azure-powershell_tmp/initOutput.json not found to read
error	Fatal error: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'
ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'
error	Fatal error: Error: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'    at Object.openSync (node:fs:596:3)    at Object.writeFileSync (node:fs:2322:35)    at writeTmpJsonFile (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/fsUtils.js:125:18)    at workflowCallGenerateScript (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:582:36)    at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:235:46)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)    at async workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:107:9)    at async sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:217:13)    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18
error	ERROR: The 'breakingChangesLabel' configuration is missing or incorrect from the 'swagger_to_sdk_config.json file.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-04-29T16:24:53Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/compute/armcompute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Java	azure-resourcemanager-compute-generated	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
JavaScript	@azure/arm-compute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.
Swagger	Microsoft.Compute	Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI.

openapi-workflow-bot · 2024-04-29T16:35:23Z

This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Learn more at aka.ms/azsdk/pr-arm-review.

martinezdylan · 2024-04-29T16:59:12Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ Your PR has at least one breaking change (label: BreakingChangeReviewRequired). See the PR description for help.

❌ The required check named Swagger BreakingChange has failed. Refer to the check in the PR's 'Checks' tab for details on how to fix it. In addition, refer to step 1 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Can we skip BreakingChange review as this feature is not currently used by any customers? Original feature addition was placed in public repo however this property is consumed by Security Posture which is in pursuit of Private Preview. The securityPostureReference will be ignored by CRP for VMSS provisioning as it's behind AFEC and Regional Flags.

razvanbadea-msft · 2024-05-25T11:48:18Z

/azp run

azure-pipelines · 2024-05-25T11:48:35Z

Azure Pipelines successfully started running 4 pipeline(s).

razvanbadea-msft · 2024-05-26T07:49:07Z

Fix the required checks

…n version

martinezdylan · 2024-05-28T16:04:53Z

There was an extra ',' in the schema causing validation issues, this has been fixed & pushed for new checks. Seems all that's left from required checks is "Breaking Changes" which is justified through bugfix label. Let me know if any additional context is needed.

raych1 · 2024-05-30T07:17:08Z

@martinezdylan , the type change of excludeExtensions property will cause breaking change to SDK. Are you saying security posture feature is in private preview and because it is behind feature flag, it doesn't have real customer impact? Is this a service behavior change?

martinezdylan · 2024-05-30T19:36:31Z

@martinezdylan , the type change of excludeExtensions property will cause breaking change to SDK. Are you saying security posture feature is in private preview and because it is behind feature flag, it doesn't have real customer impact? Is this a service behavior change?

Hi @raych1 , understood & exactly absolutely no customers have been onboarded to the service as we haven't even reached private preview as of yet. Zero customer impact. Much better CX whenever we do release.

grizzlytheodore · 2024-06-03T20:53:24Z

who can we ping about go sdk breaking change sign off?

martinezdylan · 2024-06-05T15:28:26Z

/pr RequestMerge

martinezdylan requested review from MS-syh2qs, Sandido, dkulkarni-ms, grizzlytheodore and haagha as code owners April 29, 2024 16:24

martinezdylan force-pushed the release-compute-Microsoft.Compute-stable/2024-03-01-securitypostureref branch from b9fc59a to b71e51f Compare April 29, 2024 16:26

azure-sdk added the BreakingChange-Go-Sdk label Apr 29, 2024

azure-sdk mentioned this pull request Apr 29, 2024

[AutoPR Azure.ResourceManager.Compute] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-net#7862

Closed

This was referenced Apr 29, 2024

[AutoPR azure-resourcemanager-compute-generated] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-java#10335

Closed

[AutoPR @azure/arm-compute] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-js#9711

Closed

azure-sdk added the BreakingChange-JavaScript-Sdk label Apr 29, 2024

azure-sdk mentioned this pull request Apr 29, 2024

[AutoPR Az.compute.DefaultTag] Update securityPostureReference in VMScaleSet API azure-sdk/azure-powershell#6506

Closed

azure-sdk mentioned this pull request Apr 29, 2024

[AutoPR azure-mgmt-compute] Update securityPostureReference in VMScaleSet API azure-sdk/azure-sdk-for-python#7028

Closed

martinezdylan added the BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior label May 1, 2024

martinezdylan force-pushed the release-compute-Microsoft.Compute-stable/2024-03-01-securitypostureref branch from b71e51f to 7161eff Compare May 1, 2024 18:38

AzureRestAPISpecReview added NotReadyForARMReview and removed ARMChangesRequested labels May 1, 2024

AzureRestAPISpecReview removed BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels May 24, 2024

Dylan Martinez added 11 commits May 28, 2024 08:10

update securityPostureRef properties in VMScaleSet spec

98b386f

add securityPostureReference to UpdateVMProfile definition and fix mi…

75ee1fe

…n version

add prettier changes

2ca7291

remove unsupported 'major.*' from spec

198f2d1

add optional fields in security posture example

f742eea

add required fields

0f8032d

correct minimum api version

c8a369e

add prettier fixes

283d7e3

remove extensionsSettings property

2431064

create new Update model for security posture reference & update

fbd440f

fix validation issue

19c12c8

msyyc and others added 3 commits May 29, 2024 10:31

Create sdk-suppressions.yaml

e6c4fd8

add azure-sdk-for-go suppression

3c59e22

Update sdk-suppressions.yaml

8434bfb

rkmanda approved these changes Jun 5, 2024

View reviewed changes

AkhilaIlla mentioned this pull request Jun 24, 2024

Akhilailla/fix properties type object no definition false negatives Azure/azure-openapi-validator#718

Merged

Alancere mentioned this pull request Jul 10, 2024

[Release] sdk/resourcemanager/compute/armcompute/6.0.0 Azure/azure-sdk-for-go#23129

Merged

weidongxu-microsoft mentioned this pull request Jul 16, 2024

Remove useref and Fleet update changes #29493

Merged

7 tasks

kazrael2119 mentioned this pull request Jul 25, 2024

[mgmt] compute release Azure/azure-sdk-for-js#30423

Merged

martinezdylan mentioned this pull request Sep 4, 2024

Update Security Posture Reference on az vmss create and az vmss update commands Azure/azure-cli#29846

Closed

1 task

Conversation

martinezdylan commented Apr 29, 2024

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Diagram footnotes

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app Bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app Bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app Bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Uh oh!

openapi-pipeline-app Bot commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

openapi-workflow-bot Bot commented Apr 29, 2024

Uh oh!

martinezdylan commented Apr 29, 2024

Next Steps to Merge

Uh oh!

razvanbadea-msft commented May 25, 2024

Uh oh!

azure-pipelines Bot commented May 25, 2024

Uh oh!

razvanbadea-msft commented May 26, 2024

Uh oh!

martinezdylan commented May 28, 2024

Uh oh!

raych1 commented May 30, 2024

Uh oh!

martinezdylan commented May 30, 2024

Uh oh!

grizzlytheodore commented Jun 3, 2024

Uh oh!

martinezdylan commented Jun 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

openapi-pipeline-app Bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app Bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app Bot commented Apr 29, 2024 •

edited

Loading

openapi-pipeline-app Bot commented Apr 29, 2024 •

edited

Loading