Skip to content

Add e2e tls to latest releases #29904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
naveedaz merged 1 commit into from
Jul 31, 2024
+8 −0
Merged

Add e2e tls to latest releases #29904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions specification/web/resource-manager/Microsoft.Web/stable/2023-12-01/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3007,6 +3007,10 @@
"description": "client certificate authentication comma-separated exclusion paths",
"type": "string"
},
"endToEndEncryptionEnabled": {
"description": "Whether to use end to end encryption between the FrontEnd and the Worker",
"type": "boolean"
},
"hostNamesDisabled": {
"description": "<code>true</code> to disable the public hostnames of the app; otherwise, <code>false</code>.\n If <code>true</code>, the app is only accessible via API management process.",
"type": "boolean"
Expand Down
4 changes: 4 additions & 0 deletions specification/web/resource-manager/Microsoft.Web/stable/2024-04-01/CommonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3007,6 +3007,10 @@
"description": "client certificate authentication comma-separated exclusion paths",
"type": "string"
},
"endToEndEncryptionEnabled": {
Copy link
Copy Markdown
Member

@razvanbadea-msft razvanbadea-msft Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endToEndEncryptionEnabled

In place of adding a boolean flag you should use an enum like EncryptionType with values like [EndToEnd, None], in this way if in the future versions you are enabling another type of encryption it will just add a new value to the enum in place of other properties #Resolved

Copy link
Copy Markdown
Contributor Author

@crosenblatt crosenblatt Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature is already implemented in our backend using a boolean. We are happy with it this way.

"description": "Whether to use end to end encryption between the FrontEnd and the Worker",
"type": "boolean"
},
"hostNamesDisabled": {
"description": "<code>true</code> to disable the public hostnames of the app; otherwise, <code>false</code>.\n If <code>true</code>, the app is only accessible via API management process.",
"type": "boolean"
Expand Down
⚡