Phone Numbers API version 2025-04-01#32573
Merged
danielortega-msft merged 27 commits intomainfrom Mar 31, 2025
Merged
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
github-actions
Bot
added
the
brownfield
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
danielortega-msft
force-pushed
the
danielortega-msft/phonenumbers-cherrypicker-dnr-ga
branch
from
5dd4ba1 to
183b580
Compare
Contributor
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from 2025-02-11 to 2025-04-01
danielortega-msft
force-pushed
the
danielortega-msft/phonenumbers-cherrypicker-dnr-ga
branch
from
183b580 to
7ab1f79
Compare
Contributor
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
danielortega-msft
added
PublishToCustomers
AzureRestAPISpecReview
added
resource-manager
RPaaS
TypeSpec
Contributor
Author
|
/azp run openapi-pipeline-app |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Member
|
I pushed a change to this PR I believe should fix the problem in LintDiff: The root cause, is So, if But if I believe my change is effectively a no-op for your spec, because the I also believe my change should be non-breaking, since I left the other copy of Tracking: Azure/azure-openapi-validator#775 |
Contributor
Author
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
…ers.json Prevents circular references
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
AzureRestAPISpecReview
removed
the
BreakingChangeReviewRequired
danielortega-msft
deleted the
danielortega-msft/phonenumbers-cherrypicker-dnr-ga
branch
nwnt
pushed a commit
to nwnt/azure-rest-api-specs
that referenced
this pull request
Jun 10, 2025
* Copy files from stable/2025-02-11 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to 2025-04-01 Updated the API version from 2025-02-11 to 2025-04-01 * Added tag for 2025-04-01 in readme file * Fix readme * Add changes for phone numbers version 2025-04-01 * Fix CI * Avoid nested object def in phonenumbers swagger * Make common error responses consistent * Add missing property descriptions * Address ARB feedback for reservations API * Add description to PhoneNumbersReservation and specify ID formatting * Update do not resell field names and descriptions * Rename 'isDoNotResellAgreementRequired' to 'isAgreementToNotResellRequired' for consistency across phone number specifications * minor fixes * Add note on old reservation cleanup * Move CommunicationErrorResponse into separate file to allow circular reference detection * Add error.json to readme.md to fix Avocado * Address applicable lintdiff warnings * Define CommunicationError and CommunicationErrorResponse in phonenumbers.json Prevents circular references * consolidate CommunicationError references * remove CommunicationError from phonenumbers.json * define CommunicationErrorResponse inline * add nullable to phone numbers in reservation * Rename operationId to match convention --------- Co-authored-by: Mike Harder <mharder@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
❔Got questions? Need additional info?? We are here to help!
Contact us!
The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.
Click here for links to tools, specs, guidelines & other good stuff
Tooling
Guidelines & Specifications
Helpful Links
Getting help
write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.