Skip to content

[extendedlocation] Tsp conversion#42299

Merged
pshao25 merged 14 commits intoAzure:mainfrom
cxznmhdcxz:ruih/extendedlocation-tsp-convert
Apr 16, 2026
Merged

[extendedlocation] Tsp conversion#42299
pshao25 merged 14 commits intoAzure:mainfrom
cxznmhdcxz:ruih/extendedlocation-tsp-convert

Conversation

@cxznmhdcxz
Copy link
Copy Markdown
Member

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added resource-manager TypeSpec Authored with TypeSpec VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Apr 13, 2026
@cxznmhdcxz cxznmhdcxz force-pushed the ruih/extendedlocation-tsp-convert branch from c8761d4 to 41b9269 Compare April 13, 2026 06:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 14, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.ExtendedLocation-CustomLocations
TypeSpec Microsoft.ExtendedLocation
Go sdk/resourcemanager/extendedlocation/armextendedlocation
Python azure-mgmt-extendedlocation
JavaScript @azure/arm-extendedlocation
Java com.azure.resourcemanager:azure-resourcemanager-extendedlocation

Comment on lines +324 to +331
{
"name": "parameters",
"in": "body",
"description": "The updatable fields of an existing Custom Location.",
"required": true,
"schema": {
"$ref": "#/definitions/patchableCustomLocations"
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original swagger x-ms-client-flatten is true:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@v-jiaodi
Copy link
Copy Markdown
Member

JS codegen Support flatten parameter optional properties model Azure/autorest.typescript#3919

@pshao25 pshao25 added Approved-LintDiff BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 labels Apr 16, 2026
@github-actions github-actions Bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Apr 16, 2026
@pshao25 pshao25 added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Apr 16, 2026
@github-actions github-actions Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 16, 2026
@pshao25 pshao25 merged commit 318086e into Azure:main Apr 16, 2026
123 of 127 checks passed
Ealianis pushed a commit that referenced this pull request Apr 17, 2026
* tsp init

* update code and tspconfig init

* update example

* update

* update

* Update tspconfig.yaml

* Update client.tsp

* Update client.tsp

* update param flatten

* update

* update

* update

* revert

---------

Co-authored-by: Jiao Di (MSFT) <v-jiaodi@microsoft.com>
Co-authored-by: v-huizhu2 <v-huizhu2@microsoft.com>
Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>
Co-authored-by: Pan Shao <97225342+pshao25@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager TypeSpec Authored with TypeSpec typespec-conversion-w7 Versioning-Approved-Benign https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants