Add encryption scope API to 2019-06-01. by anthonykjose · Pull Request #8381 · Azure/azure-rest-api-specs

anthonykjose · 2020-02-12T22:11:18Z

This change introduces the encryption scope API for storage RP. Encryption scopes are a nested proxy resource under the Microsoft.Storage/storageAccounts top-level ARM resource. This api is offered beginning with api-version 2019-06-01. The following operations are supported:

GET Encryption Scope.
LIST Encryption Scope.
PUT Encryption Scope.
PATCH Encryption Scope.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Add encryption scope API to 2019-06-01.

AutorestCI · 2020-02-12T22:11:21Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

msftclas · 2020-02-12T22:11:31Z

All CLA requirements met.

akning-ms · 2020-02-13T05:32:35Z

/azp run automation - sdk

azure-pipelines · 2020-02-13T05:32:44Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-02-13T05:34:46Z

azure-sdk-for-net

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ec2e414 with merge commit a86098f305c16312a222c2ffaca1538f9d5b7718. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Storage [Logs] [Preview SDK Changes]

openapi-sdkautomation · 2020-02-13T05:34:46Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ec2e414 with merge commit a86098f305c16312a222c2ffaca1538f9d5b7718. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-storage [Logs] [Preview SDK Changes]

[after_scripts|python] WARNING:__main__:Found too much API version: {'2018-07-01', '2018-03-01-preview'} in label v2018_07_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-07-01 based on label v2018_07_01
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-02-13T05:34:52Z

azure-sdk-for-java

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ec2e414 with merge commit a86098f305c16312a222c2ffaca1538f9d5b7718. SDK Automation 13.0.17.20191226.1
️✔️sdk/storage/mgmt-v2016_01_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2017_10_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_02_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_03_01_preview [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2018_07_01 [Logs] [Preview SDK Changes]
️✔️sdk/storage/mgmt-v2019_04_01 [Logs] [Preview SDK Changes]

⚠️sdk/storage/mgmt-v2019_06_01 [Logs] [Preview SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[73,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn]   symbol:   class SkuInner
[mvn]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-storage: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/BlobServiceProperties.java:[73,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.BlobServiceProperties
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/storage/mgmt-v2019_06_01/src/main/java/com/microsoft/azure/management/storage/v2019_06_01/FileServiceProperties.java:[49,5] cannot find symbol
[mvn] [ERROR]   symbol:   class SkuInner
[mvn] [ERROR]   location: interface com.microsoft.azure.management.storage.v2019_06_01.FileServiceProperties
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

openapi-sdkautomation · 2020-02-13T05:34:54Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from ec2e414 with merge commit a86098f305c16312a222c2ffaca1538f9d5b7718. SDK Automation 13.0.17.20191226.1
⚠️preview/storage/mgmt/2015-05-01-preview [Logs]
```
No file is changed.
```
⚠️preview/storage/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2015-06-15 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-01-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-05-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2016-12-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-06-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2017-10-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-02-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-07-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2018-11-01 [Logs]
```
No file is changed.
```
⚠️storage/mgmt/2019-04-01 [Logs]
```
No file is changed.
```
️✔️storage/mgmt/2019-06-01 [Logs] [Preview SDK Changes]
- storage.mgmt.2019-06-01.zip

openapi-sdkautomation · 2020-02-13T05:46:44Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from ec2e414 with merge commit f23a39fcbd0b622edd0d053af609cf192dd8f7e3. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-storage [Logs] [Preview SDK Changes]

azure-arm-storage-13.1.0.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/storageManagementClient.js → ./dist/arm-storage.js...
[npmPack] created ./dist/arm-storage.js in 481ms

majastrz

Signed off from ARM side.

* Add encryption scope API to 2019-06-01. Add encryption scope API to 2019-06-01. * Address CI failures. * Fix CI failures Azure#2. * Address CI failures Azure#3. Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>

* Add encryption scope API to 2019-06-01. Add encryption scope API to 2019-06-01. * Address CI failures. * Fix CI failures #2. * Address CI failures Azure#3. Co-authored-by: Anthony Kunnel Jose <antjo@microsoft.com>

Add encryption scope API to 2019-06-01.

dad1f16

Add encryption scope API to 2019-06-01.

openapi-assignment-bot Bot assigned akning-ms Feb 12, 2020

tonykjose added 3 commits February 12, 2020 14:26

Address CI failures.

dc544e2

Fix CI failures #2.

233b8a0

Address CI failures #3.

ec2e414

akning-ms added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 13, 2020

openapi-sdkautomation Bot mentioned this pull request Feb 13, 2020

[AutoPR @azure/arm-storage] Add encryption scope API to 2019-06-01. AzureSDKAutomation/azure-sdk-for-js#432

Open

anthonykjose mentioned this pull request Feb 13, 2020

Request to support Encryption Scopes for Microsoft.Storage. Azure/azure-cli#12188

Closed

majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 13, 2020

majastrz approved these changes Feb 13, 2020

View reviewed changes

akning-ms merged commit 74cf8e9 into Azure:master Feb 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add encryption scope API to 2019-06-01.#8381

Add encryption scope API to 2019-06-01.#8381
akning-ms merged 4 commits intoAzure:masterfrom
tonykjose:master

anthonykjose commented Feb 12, 2020 •

edited

Loading

Uh oh!

AutorestCI commented Feb 12, 2020

Uh oh!

msftclas commented Feb 12, 2020 •

edited

Loading

Uh oh!

akning-ms commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

Uh oh!

majastrz left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

anthonykjose commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Feb 12, 2020

Uh oh!

msftclas commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akning-ms commented Feb 13, 2020

Uh oh!

azure-pipelines Bot commented Feb 13, 2020

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

openapi-sdkautomation Bot commented Feb 13, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

majastrz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anthonykjose commented Feb 12, 2020 •

edited

Loading

msftclas commented Feb 12, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading

openapi-sdkautomation Bot commented Feb 13, 2020 •

edited

Loading