-
Notifications
You must be signed in to change notification settings - Fork 154
KeyVault: Fix test failures #5112
Copy link
Copy link
Closed
Labels
ClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.KeyVaultneeds-team-triageWorkflow: This issue needs the team to triage.Workflow: This issue needs the team to triage.
Metadata
Metadata
Assignees
Labels
ClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.KeyVaultneeds-team-triageWorkflow: This issue needs the team to triage.Workflow: This issue needs the team to triage.
Type
Projects
Status
Done
The reason for this, I think, is that after the change that enabled running live tests against WinHTTP transport, and a few subsequent fixes to record and playback (updated regex for secrets, removed cookie from recordings), KeyVault pipeline started to fail, and we need to update the recordings (Storage did that - https://github.com/Azure/azure-sdk-for-cpp/pull/5070/files#diff-8197b617f0faa3471ca4ae5d7bc8ed10aaf1c67656cdd7071570cd08994d3a88R5).
Possibility number 2 - we need to update WinHTTP transport to closer align with the libcurl transport (see https://github.com/Azure/azure-sdk-for-cpp/pull/5071/files#r1373997631).
Either way, please make the
/azp run cpp - keyvault - ciand/azp run cpp - keyvaultgreen.