-
Notifications
You must be signed in to change notification settings - Fork 154
Nullable::Emplace doesn't set m_hasValue = true #5172
Copy link
Copy link
Closed
Labels
Azure.CoreClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.customer-reportedIssues that are reported by GitHub users external to the Azure organization.Issues that are reported by GitHub users external to the Azure organization.needs-team-triageWorkflow: This issue needs the team to triage.Workflow: This issue needs the team to triage.questionThe issue doesn't require a change to the product in order to be resolved. Most issues start as thatThe issue doesn't require a change to the product in order to be resolved. Most issues start as that
Metadata
Metadata
Assignees
Labels
Azure.CoreClientThis issue points to a problem in the data-plane of the library.This issue points to a problem in the data-plane of the library.customer-reportedIssues that are reported by GitHub users external to the Azure organization.Issues that are reported by GitHub users external to the Azure organization.needs-team-triageWorkflow: This issue needs the team to triage.Workflow: This issue needs the team to triage.questionThe issue doesn't require a change to the product in order to be resolved. Most issues start as thatThe issue doesn't require a change to the product in order to be resolved. Most issues start as that
Describe the bug
Azure::Nullable::Emplacecreates an object asm_valuebut forgets to setm_hasValue = true.Code Snippet
Expected behavior
Emplaceshould actually engage theNullableobject, just likestd::optional::emplace.Setup (please complete the following information):
The bug still exists in trunk at the time of my writing:
azure-sdk-for-cpp/sdk/core/azure-core/inc/azure/core/nullable.hpp
Line 220 in 1b2e58f