Remove warning supress#2677
Merged
vhvb1989 merged 4 commits intoAzure:mainfrom Jul 28, 2021
Merged
Conversation
vhvb1989
requested review from
RickWinter,
ahsonkhan,
antkmsft,
gearama and
schaabs
as code owners
vhvb1989
added
Azure.Core
Client
antkmsft
approved these changes
Jul 28, 2021
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #2474
Updating the code to remove the include of libcurl header from files not utilizing it.
The header is now included from the private_connection which is consumed by curl.cpp implementation.
Also adding nlohmann/json#2673 to the json lib implementation.
With this PR, we can use MSVC on Windows again to fully compile with /analyse ON