Skip to content

force http 1.1 on the libcurl transport adapter#2978

Merged
vhvb1989 merged 2 commits intoAzure:mainfrom
vhvb1989:use-http-1.1-for-libcurl-trasport
Oct 20, 2021
Merged

force http 1.1 on the libcurl transport adapter#2978
vhvb1989 merged 2 commits intoAzure:mainfrom
vhvb1989:use-http-1.1-for-libcurl-trasport

Conversation

@vhvb1989
Copy link
Copy Markdown
Member

@vhvb1989 vhvb1989 commented Oct 19, 2021

fixes: #2848
HTTP/2 is the default but the implementation is not ready to support it.

@vhvb1989 vhvb1989 self-assigned this Oct 19, 2021
@vhvb1989 vhvb1989 added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Oct 19, 2021
@vhvb1989 vhvb1989 added this to the [2021] November milestone Oct 19, 2021
Copy link
Copy Markdown
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the string this looks good.

Comment thread sdk/core/azure-core/src/http/curl/curl.cpp Outdated
@ahsonkhan
Copy link
Copy Markdown
Contributor

ahsonkhan commented Oct 19, 2021

HTTP/2 is the default but the implementation is not ready to support it.

Do we have an issue to track this work?
#2982

Comment thread sdk/core/azure-core/CHANGELOG.md
Copy link
Copy Markdown
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert #2948 then?

@vhvb1989 vhvb1989 enabled auto-merge (squash) October 20, 2021 00:07
Comment thread sdk/core/azure-core/src/http/curl/curl.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure C++ sdk for Secret related operation (Like GetSecret() )not working on Ubunut 20.04 but same code working on ubuntu18.04

5 participants