Remove a private internal method that is not used.#4667
Merged
RickWinter merged 1 commit intoAzure:mainfrom Jun 9, 2023
Merged
Remove a private internal method that is not used.#4667RickWinter merged 1 commit intoAzure:mainfrom
RickWinter merged 1 commit intoAzure:mainfrom
Conversation
RickWinter
requested review from
EmmaZhu,
Jinming-Hu,
ahsonkhan,
antkmsft,
gearama,
microzchang,
vhvb1989 and
vinjiang
as code owners
github-actions
Bot
added
Azure.Core
KeyVault
Storage
antkmsft
reviewed
May 30, 2023
Member
antkmsft
left a comment
antkmsft
left a comment
There was a problem hiding this comment.
LGTM, but let's wait until after this month release (releasing this would require releasing all libraries), and let's still mention it in the changelog in Breaking Changes section.
ahsonkhan
reviewed
Jun 6, 2023
Member
|
See also #4749 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused private virtual method
Fixes #4662