clang-13 version of cstdlib doesn't define integer types in global na…#5031
Merged
LarryOsterman merged 8 commits intoAzure:mainfrom Oct 17, 2023
Merged
clang-13 version of cstdlib doesn't define integer types in global na…#5031LarryOsterman merged 8 commits intoAzure:mainfrom
LarryOsterman merged 8 commits intoAzure:mainfrom
Conversation
LarryOsterman
requested review from
RickWinter,
ahsonkhan,
antkmsft,
gearama and
vhvb1989
as code owners
LarryOsterman
requested review from
benbp,
danieljurek and
weshaggard
as code owners
7 tasks
Member
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ahsonkhan
reviewed
Oct 12, 2023
Member
Author
|
Ping :). |
Contributor
That sounds like a great solution and one we can put in the SDK guidelines. |
ahsonkhan
reviewed
Oct 13, 2023
ahsonkhan
reviewed
Oct 13, 2023
ahsonkhan
reviewed
Oct 13, 2023
danieljurek
reviewed
Oct 13, 2023
RickWinter
reviewed
Oct 17, 2023
RickWinter
approved these changes
Oct 17, 2023
Member
RickWinter
left a comment
RickWinter
left a comment
There was a problem hiding this comment.
Add a comment that we will remove the header in future cleanup. Otherwise LGTM
ahsonkhan
approved these changes
Oct 17, 2023
Contributor
ahsonkhan
left a comment
ahsonkhan
left a comment
There was a problem hiding this comment.
Fingers crossed this fixes the customer's vcpkg install issue :)
LarryOsterman
commented
Oct 17, 2023
LarryOsterman
commented
Oct 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…mespace
Fixes #5007
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.