Skip to content

Fix use of namespace qualifiers that have not been explicitly introduced #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antkmsft merged 4 commits into from
Feb 29, 2024
Merged

Fix use of namespace qualifiers that have not been explicitly introduced #5371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0fd5b16
Fix use of namespace qualifiers that have not been explicitly introdu…
Feb 21, 2024
f88dfd9
Format (sort usings alphabetically)
antkmsft Feb 27, 2024
122f2d1
Update CHANGELOG.md
antkmsft Feb 29, 2024
e2aad98
Update cspell.json
antkmsft Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .vscode/cspell.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@
"MHSM",
"mmdc",
"mmspecial",
"morten",
"moxygen",
"MSAL",
"msft",
Expand All @@ -175,8 +176,9 @@
"nostd",
"nread",
"NTSTATUS",
"odata",
"Oaep",
"odata",
"ofstad",
"OIDC",
"okhttp",
"opentelemetry",
Expand Down
8 changes: 7 additions & 1 deletion sdk/core/azure-core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@

### Bugs Fixed

### Other Changes
- [[#4352]](https://github.com/Azure/azure-sdk-for-cpp/pull/5371) Fixed compilation error on Visual Studio 2017. (A community contribution, courtesy of _[morten-ofstad](https://github.com/morten-ofstad)_)

### Acknowledgments

Thank you to our developer community members who helped to make Azure Core better with their contributions to this release:

- Morten Ofstad _([GitHub](https://github.com/morten-ofstad))_

## 1.11.2 (2024-02-16)

Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core/src/credentials/authorization_challenge_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ bool TryGetNextParameter(StringSpan& headerValue, StringSpan& paramKey, StringSp
std::string const EmptyString;
} // namespace

std::string const& AuthorizationChallengeHelper::GetChallenge(Http::RawResponse const& response)
std::string const& AuthorizationChallengeHelper::GetChallenge(RawResponse const& response)
{
// See RFC7235 (https://www.rfc-editor.org/rfc/rfc7235#section-4.1)
if (response.GetStatusCode() == HttpStatusCode::Unauthorized)
Expand Down
3 changes: 2 additions & 1 deletion sdk/core/azure-core/src/http/bearer_token_authentication_policy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ using Azure::Core::Credentials::AuthenticationException;
using Azure::Core::Credentials::TokenRequestContext;
using Azure::Core::Credentials::_detail::AuthorizationChallengeHelper;
using Azure::Core::Http::RawResponse;
using Azure::Core::Http::Request;
using Azure::Core::Http::Policies::NextHttpPolicy;

std::unique_ptr<RawResponse> BearerTokenAuthenticationPolicy::Send(
Expand Down Expand Up @@ -83,7 +84,7 @@ void ApplyBearerToken(

void BearerTokenAuthenticationPolicy::AuthenticateAndAuthorizeRequest(
Request& request,
Credentials::TokenRequestContext const& tokenRequestContext,
TokenRequestContext const& tokenRequestContext,
Context const& context) const
{
DateTime const currentTime = std::chrono::system_clock::now();
Expand Down
⚡