Skip to content

Remove final keyword for RetryPolicy so that storage SDK can inherit from it #5530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jinming-Hu wants to merge 11 commits into from
Closed

Remove final keyword for RetryPolicy so that storage SDK can inherit from it #5530

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9057184
Update policy.hpp
Jinming-Hu Apr 15, 2024
0b5f23d
add storage retry policy
Jinming-Hu Apr 16, 2024
e737df6
clang-format
Jinming-Hu Apr 16, 2024
3ae250b
virtual destructor
Jinming-Hu Apr 16, 2024
d732886
Remove unused header
Jinming-Hu Apr 16, 2024
88861ce
update
Jinming-Hu Apr 17, 2024
5e4965e
construct pipeline
Jinming-Hu Apr 18, 2024
f7535a4
fix
Jinming-Hu Apr 18, 2024
77df2c1
Add include header
Jinming-Hu Apr 19, 2024
ec00985
fix build error
Jinming-Hu Apr 19, 2024
50cb16c
fix
Jinming-Hu Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sdk/core/azure-core/inc/azure/core/http/policies/policy.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,11 +363,7 @@ namespace Azure { namespace Core { namespace Http { namespace Policies {
/**
* @brief HTTP retry policy.
*/
class RetryPolicy
#if !defined(_azure_TESTING_BUILD)
final
#endif
: public HttpPolicy {
class RetryPolicy : public HttpPolicy {
Comment thread
Jinming-Hu marked this conversation as resolved.
private:
RetryOptions m_retryOptions;

Expand Down
⚡