Skip to content

Use client assertion credential within AzurePipelinesCredential and WorkloadIdentityCredential#5802

Merged
ahsonkhan merged 8 commits intoAzure:mainfrom
ahsonkhan:UseClientAssertionCredential
Aug 2, 2024
Merged

Use client assertion credential within AzurePipelinesCredential and WorkloadIdentityCredential#5802
ahsonkhan merged 8 commits intoAzure:mainfrom
ahsonkhan:UseClientAssertionCredential

Conversation

@ahsonkhan
Copy link
Copy Markdown
Contributor

Fixes #4905

Follow-up to #5789

@ahsonkhan ahsonkhan self-assigned this Jul 16, 2024
@ahsonkhan

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as duplicate.

Comment thread sdk/identity/azure-identity/src/private/tenant_id_resolver.hpp
Comment thread sdk/identity/azure-identity/test/ut/azure_pipelines_credential_test.cpp Outdated
@ahsonkhan

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as duplicate.

Comment thread sdk/identity/azure-identity/src/azure_pipelines_credential.cpp Outdated
Comment thread sdk/identity/azure-identity/src/workload_identity_credential.cpp Outdated
Comment thread sdk/identity/azure-identity/src/azure_pipelines_credential.cpp Outdated
@ahsonkhan
Copy link
Copy Markdown
Contributor Author

/azp run cpp - identity

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ahsonkhan ahsonkhan added this to the 2024-08 milestone Jul 29, 2024
@ahsonkhan
Copy link
Copy Markdown
Contributor Author

Any other feedback or thoughts before I merge this?

Comment thread sdk/identity/azure-identity/src/workload_identity_credential.cpp Outdated
Comment thread sdk/identity/azure-identity/inc/azure/identity/azure_pipelines_credential.hpp Outdated
Comment thread sdk/identity/azure-identity/test/ut/default_azure_credential_test.cpp Outdated
@ahsonkhan
Copy link
Copy Markdown
Contributor Author

/azp run cpp - identity

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Member

@antkmsft antkmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ahsonkhan ahsonkhan merged commit 5fd26a6 into Azure:main Aug 2, 2024
@ahsonkhan ahsonkhan deleted the UseClientAssertionCredential branch August 2, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

Consider creating ClientAssertionCredential and implementing WorkloadIdentityCredential in terms of it

5 participants