Backup Tests redo PR#5916
Merged
gearama merged 3 commits intoAzure:mainfrom Aug 15, 2024
Merged
Conversation
RickWinter
approved these changes
Aug 15, 2024
ahsonkhan
reviewed
Aug 16, 2024
Comment on lines
+599
to
+600
| std::cout << std::endl << "retries reached 0"; | ||
| EXPECT_TRUE(false); |
Contributor
There was a problem hiding this comment.
FYI: Another mechanism to add output messages for tests that fail, instead of cout, is use the gtest feature.
EXPECT_TRUE(<put condition here>) << <put your log message here>;
This way, you only output that error message if the test assertion fails.
You can also use: GTEST_LOG_INFO. We have a few places in test that do that already.
In cases like this, where you want to fail a test if it reaches this point, rather than using EXPECT_TRUE(false), you can see GTEST_FAIL with an output message appended to it
Here are a couple example usages of that:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR(https://github.com/Azure/azure-sdk-for-cpp/pull/5888/files) got deleted before merging.
Thank you @ahsonkhan for catching it.
closes #5823
closes #5821
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.