You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The primary behavior change is: if an assets.json file is found in the current test service directory or any parent, the recording framework will request external assets via the test proxy during test setup. If there is no assets.json, then pre-existing recordings will be used instead. This change should support running tests via run_tests.ps1 or invoking go test directly.
I also added some minor improvements to the testing scripts.
Improve error and pipeline handling in run_tests.ps1
Add test proxy default assets directory to gitignore
Support test proxy external asset mode for test recordings
@jhendrixMSFT@richardpark-msft do you anticipate a future requirement to define configs for recording assets in directories below the service directory (e.g. deeper than sdk/keyvault/azkeys)? That is to say, will we need more granularity with recordings than the main package? I've skipped that functionality for now assuming it won't be needed.
In azblob there are tests in subdirectories. Does this mean the feature is required?
It's a weird scenario I'm thinking of where you would have tests in a sub-directory, and an asset configuration for those test recordings in the sub-directory, but you invoke the tests from a parent directory (either with ./... or like ./container/...). Let me dig back into it.
Alright, the latest update is much more flexible with the working directory of go test and the asset config path relative to the recording directory (anywhere at or above), as well as fixing some windows file and root detection issues. It does require that tests be run from within a git repository, i.e. this won't work if you have downloaded the repo code without .git, but I don't anticipate this will be an issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Central-EngSysThis issue is owned by the Engineering System team.EngSysThis issue is impacting the engineering system.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Azure/azure-sdk-tools#4257
This adds support to the recording package to work with test proxy asset sync, which will allow the test recordings to be moved out of the go repository into https://github.com/Azure/azure-sdk-assets.
The primary behavior change is: if an
assets.jsonfile is found in the current test service directory or any parent, the recording framework will request external assets via the test proxy during test setup. If there is noassets.json, then pre-existing recordings will be used instead. This change should support running tests viarun_tests.ps1or invokinggo testdirectly.I also added some minor improvements to the testing scripts.