Adding isAll and isNone as read-only methods#29809
Merged
ibrahimrabab merged 2 commits intomainfrom Jul 7, 2022
Merged
Conversation
ibrahimrabab
requested review from
alzimmermsft,
jaschrep-msft,
kasobol-msft and
rickle-msft
as code owners
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
srnagar
reviewed
Jul 7, 2022
| } | ||
|
|
||
| /** | ||
| * @return whether no properties should be copied from the source file. |
Member
There was a problem hiding this comment.
There should be a description in this JavaDoc too along with @return tag doc
| * @return whether all properties should be copied from the source file. | ||
| */ | ||
| public Boolean isAll() { | ||
| return isSetFileAttributes && isSetCreatedOn && isSetLastWrittenOn && isSetChangedOn; |
Member
There was a problem hiding this comment.
Since all these are Boolean properties, this will throw NPE if any of them is null. The constructor does initialize them but the user can still call setLastWrittenOn(null) to make this property null. So, we should check for null here.
srnagar
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding isAll and isNone as read-only methods, and removing unused booleans from CopyableFileSmbProperties.