Test recorder#32668
Merged
samvaity merged 126 commits intoAzure:mainfrom Feb 28, 2023
Merged
Conversation
billwert
requested review from
JonathanGiles,
alzimmermsft,
anuchandy,
lmolkova,
mssfang,
samvaity,
srnagar and
vcolin7
as code owners
ghost
added
Contributor
Author
|
sorry for all the pings - I meant to open as a draft. :( Feedback definitely welcome at this point though! |
billwert
force-pushed
the
test-recorder
branch
from
296a30f to
e8c48b0
Compare
billwert
force-pushed
the
test-recorder
branch
from
4cd9b6f to
23b3dfd
Compare
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
* playback works! * variable stuff does not work yet and is still going to get changed
Update matcher feedback + banned dep update
Fix logic for getting response body to handle error cases.
checkstyle + updates
Contributor
Author
|
@srnagar It looks like we're done with feedback. There are a couple follow up items to do (finishing the work so that recordings can be migrated and your comment about dynamic port numbers) but otherwise this is done. Folks can start using this for re-recording. Can you sign off? |
|
Hello @billwert! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
srnagar
approved these changes
Feb 28, 2023
| * Before tests are executed, determines the test mode by reading the {@code AZURE_TEST_MODE} environment variable. | ||
| * If it is not set, {@link TestMode#PLAYBACK} | ||
| */ | ||
| @SuppressWarnings({"deprecation", "resource"}) |
Member
There was a problem hiding this comment.
If it's not needed, then let's remove this before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plumbing infrastructure for enabling out of process test recordings.
A follow up doc will come which will explain use. With a couple small exceptions all existing tests should work without change.
Wiki - TestProxy Migration
Big changes:
HttpClientimplementationCloses #33303
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines