Regenerate Job Router with stream-style serialization and remove many Internal models#40397
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
@williamzhao87 could you take a look at this PR. It's onboarding Job Router to azure-json and using code customizations to remove a lot of the mapping logic from custom to generated types but having the generated types handle the same as the custom types. |
|
@alzimmermsft Thanks for submitting the PR with these extensive changes! Everything here looks good to me. |
| */ | ||
| @Immutable | ||
| public final class CancelJobResultInternal { | ||
| public final class CancelJobResultInternal implements JsonSerializable<CancelJobResultInternal> { |
There was a problem hiding this comment.
Just curious, it's only the empty internal classes that cannot be removed, right?
There was a problem hiding this comment.
I really never figured out what to do with this class and the similar Internal classes as they're defined in the TypeSpec without any properties but are used in service methods that are hidden from the public API, so I left them. These can be followed up on if they should be removed.
Description
Regenerates
azure-communication-jobrouterwith stream-style serialization enabled. Additionally, adds numerous code customizations so that the*Internalmodel mapping pattern can be reduced greatly, lowering maintenance costs and possible bugs when mapping handwritten models to generated models.There will need to be a corresponding change in
azure-rest-api-specsbased on what I changed manually inmodels.tspandtspconfig.ymlwhile creating this PR. I will open that PR once this has approval.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines