Skip to content

Update keyvault sample to use AzureCliCredential for testing#30449

Closed
ahsonkhan wants to merge 10 commits intomainfrom
ahsonkhan-patch-1
Closed

Update keyvault sample to use AzureCliCredential for testing#30449
ahsonkhan wants to merge 10 commits intomainfrom
ahsonkhan-patch-1

Conversation

@ahsonkhan
Copy link
Copy Markdown
Contributor

@ahsonkhan ahsonkhan commented Jul 17, 2024

Not intended to merge. Just using it to test JS infra for running keyvault samples.

Investigating an issue in C++:
Azure/azure-sdk-for-cpp#5800

cc @maorleger, @weshaggard

@ahsonkhan ahsonkhan self-assigned this Jul 17, 2024
@maorleger
Copy link
Copy Markdown
Member

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@ahsonkhan
Copy link
Copy Markdown
Contributor Author

ahsonkhan commented Jul 17, 2024

@ahsonkhan

This comment was marked as duplicate.

@azure-pipelines

This comment was marked as duplicate.

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@ahsonkhan
Copy link
Copy Markdown
Contributor Author

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@ahsonkhan
Copy link
Copy Markdown
Contributor Author

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

1 similar comment
@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@maorleger
Copy link
Copy Markdown
Member

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

Pull request contains merge conflicts.

@maorleger
Copy link
Copy Markdown
Member

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ahsonkhan
Copy link
Copy Markdown
Contributor Author

So, it looks like, in the JS repo, the az cli task is successfully able to login and get the access token (and doesn't fail with an error asking to re-run az login), even though AZURE_CONFIG_DIR is set to the default C:\azureCli. That's interesting to know. Thanks!

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3974864&view=logs&j=4eaf6b84-07d0-5e66-f484-4e9defa3fc2f&t=fcabb54c-652e-505d-0dc4-2094d1b17e4d

[run-samples] Running D:\a\_work\1\s\sdk\keyvault\keyvault-keys\samples-dev\helloWorld.ts
[dev-tool/register] Rewrote import of "@azure/keyvault-keys" to "..\src\index".
CALLED AzureCliCredential ctor from source code.
...
...
azure:identity:info AzureCliCredential => getToken() => Using the scope ***
CALLED getAzureCliAccessToken from source code
azure:identity:info AzureCliCredential => getToken() => expires_on is available and is valid, using it
azure:identity:info AzureCliCredential => getToken() => SUCCESS. Scopes: ***.

@ahsonkhan
Copy link
Copy Markdown
Contributor Author

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ahsonkhan
Copy link
Copy Markdown
Contributor Author

/azp run js - keyvault-keys - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ahsonkhan
Copy link
Copy Markdown
Contributor Author

Investigation complete. Closing for now.

@ahsonkhan ahsonkhan closed this Sep 19, 2024
@ahsonkhan ahsonkhan deleted the ahsonkhan-patch-1 branch September 19, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants