Use tsconfig.src.build.json in all libraries#35242
Merged
deyaaeldeen merged 2 commits intomainfrom Jul 18, 2025
Merged
Conversation
deyaaeldeen
requested review from
a team,
HarshaNalluru,
JacksonWeber,
KarishmaGhiya,
Karlie-777,
MSNev,
MaryGao,
ShreyaAnand,
Sid200026,
andykao1213,
dargilco,
dubiety,
glharper,
hectorhdzg,
jeremydvoss,
jeremymeng,
jhakulin,
lmolkova,
lzchen,
minhanh-phan,
puagarwa,
qiaozha,
rads-1996,
rhurey,
srnagar,
trrwilson and
xirzec
as code owners
deyaaeldeen
requested review from
a team,
alexathomases,
cRui861,
dpwatrous,
johngallardo,
koen-mertens,
olivakar,
rajeshka,
shankarsama,
sjiherzig,
skapur12,
tomsft,
wanghoppe and
wiboris
as code owners
deyaaeldeen
requested review from
Haiying-MSFT,
KevinBlasko,
ToddKingMSFT,
gulopesd,
jairmyree,
joshfree and
pvaneck
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the build configuration across all Azure SDK for JavaScript libraries by switching from local tsconfig.src.json to a shared tsconfig.src.build.json configuration. This change addresses a subtle issue with tshy's browser build behavior while ensuring consistent build practices across the entire SDK repository.
- Updates tshy build configuration to use shared tsconfig
- Resolves browser build issues with tshy
- Standardizes build practices across all SDK libraries
Contributor
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
minhanh-phan
approved these changes
Jul 18, 2025
minhanh-phan
approved these changes
Jul 18, 2025
This was referenced Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching to use
tsconfig.src.build.jsonin all libraries. This standardizes how we build our libraries and resolves a subtle issue where tshy doesn't always do the right thing for the browser build when usingtsconfig.src.json.