Skip to content

Added ShareSnapshotNotFound in ShareErrorCode 99 #48975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickliu-msft merged 10 commits into from
May 13, 2025
Merged

Added ShareSnapshotNotFound in ShareErrorCode 99 #48975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0fc37b4
Generated Swagger changes for ShareSnapshotNotFoundValue added in Sha…
nickliu-msft Mar 18, 2025
1475ce0
Fixed autorest.md
nickliu-msft Mar 18, 2025
0dbcbea
fixed autorest.md
nickliu-msft Mar 18, 2025
f17d2a0
exported apis
nickliu-msft Mar 18, 2025
fd2d8a6
ShareClient.DeleteIfExists catches ShareSnapshotNotFound
nickliu-msft Mar 26, 2025
7256730
tiny test fix
nickliu-msft Mar 27, 2025
46499fc
merge conflict resolve
nickliu-msft May 13, 2025
3a501da
autorest + recorded tests
nickliu-msft May 13, 2025
0087168
merge conflict resolve
nickliu-msft May 13, 2025
9cef565
Recorded test
nickliu-msft May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.net6.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,7 @@ public ShareDirectorySetHttpHeadersOptions() { }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareNotFound { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotCountExceeded { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotInProgress { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotNotFound { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotOperationNotSupported { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode SharingViolation { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode UnsupportedHeader { get { throw null; } }
Expand Down
1 change: 1 addition & 0 deletions sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.net8.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,7 @@ public ShareDirectorySetHttpHeadersOptions() { }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareNotFound { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotCountExceeded { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotInProgress { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotNotFound { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotOperationNotSupported { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode SharingViolation { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode UnsupportedHeader { get { throw null; } }
Expand Down
1 change: 1 addition & 0 deletions sdk/storage/Azure.Storage.Files.Shares/api/Azure.Storage.Files.Shares.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,7 @@ public ShareDirectorySetHttpHeadersOptions() { }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareNotFound { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotCountExceeded { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotInProgress { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotNotFound { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode ShareSnapshotOperationNotSupported { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode SharingViolation { get { throw null; } }
public static Azure.Storage.Files.Shares.Models.ShareErrorCode UnsupportedHeader { get { throw null; } }
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/Azure.Storage.Files.Shares/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/storage/Azure.Storage.Files.Shares",
"Tag": "net/storage/Azure.Storage.Files.Shares_2664069888"
"Tag": "net/storage/Azure.Storage.Files.Shares_8e80a47735"
}
3 changes: 3 additions & 0 deletions sdk/storage/Azure.Storage.Files.Shares/src/Generated/Models/ShareErrorCode.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion sdk/storage/Azure.Storage.Files.Shares/src/ShareClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,7 +1423,8 @@ private async Task<Response<bool>> DeleteIfExistsInternal(
return Response.FromValue(true, response);
}
catch (RequestFailedException storageRequestFailedException)
when (storageRequestFailedException.ErrorCode == ShareErrorCode.ShareNotFound)
when (storageRequestFailedException.ErrorCode == ShareErrorCode.ShareNotFound
|| storageRequestFailedException.ErrorCode == ShareErrorCode.ShareSnapshotNotFound)
{
return Response.FromValue(false, default);
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/Azure.Storage.Files.Shares/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Run `dotnet build /t:GenerateCode` to generate code.

``` yaml
input-file:
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/7dcad34e88d292bc09c89b279a77d6330f5a04f8/specification/storage/data-plane/Microsoft.FileStorage/stable/2025-11-05/file.json
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/3946d872fb96fe085acd629c213b21794c756b71/specification/storage/data-plane/Microsoft.FileStorage/stable/2025-11-05/file.json
generation1-convenience-client: true
# https://github.com/Azure/autorest/issues/4075
skip-semantics-validation: true
Expand Down
17 changes: 17 additions & 0 deletions sdk/storage/Azure.Storage.Files.Shares/tests/ShareClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,23 @@ public async Task DeleteIfExistsAsync_NotExists()
Assert.IsFalse(response.Value);
}

[RecordedTest]
public async Task DeleteIfExistsAsync_SnapshotNotFound()
{
// Arrange
var shareName = GetNewShareName();
ShareServiceClient service = SharesClientBuilder.GetServiceClient_SharedKey();
ShareClient share = InstrumentClient(service.GetShareClient(shareName));
await share.CreateIfNotExistsAsync();
ShareClient shareWithSnapshot = share.WithSnapshot("2025-02-04T10:17:47.0000000Z");

// Act
Response<bool> response = await shareWithSnapshot.DeleteIfExistsAsync();

// Assert
Assert.IsFalse(response.Value);
}

[RecordedTest]
public async Task DeleteIfExistsAsync_Error()
{
Expand Down
⚡