Preview implementation of AzureCliCredential#10092
Merged
Conversation
chlowell
added
Client
chlowell
requested review from
bryevdv,
catalinaperalta,
jianghaolu,
jongio,
lmazuel,
sophiajt and
xiangyan99
|
Can one of the admins verify this patch? |
jongio
reviewed
Mar 4, 2020
| ## 1.3.1 (Unreleased) | ||
| ## 1.4.0b1 (Unreleased) | ||
| - Added `AzureCliCredential`, which authenticates with the identity logged in | ||
| to the Azure CLI. This credential is part of `DefaultAzureCredential` by |
Member
There was a problem hiding this comment.
Please sync with rest of lang devs to ensure we are on the same page across langs on whether or not DAC has CLICred by default.
I highly prefer it to be enabled by default so developer doesn't have to do anything to configure it.
lmazuel
reviewed
Mar 6, 2020
schaabs
reviewed
Mar 6, 2020
schaabs
previously approved these changes
Mar 6, 2020
schaabs
approved these changes
Mar 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This credential gets tokens by subprocessing the Azure CLI's
get-access-tokencommand, and is part ofDefaultAzureCredential.