Correct browser credential timeout error message#14773
Merged
chlowell merged 1 commit intoAzure:masterfrom Oct 26, 2020
Merged
Conversation
chlowell
added
Client
mccoyp
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Python 2.7, when
InteractiveBrowserCredential.get_tokentimes out waiting for a user to authenticate it raisesClientAuthenticationError('Authentication failed: [Errno 9] Bad file descriptor'). That's the right error but the wrong message. The right message, as seen on Python 3.x, is "Timed out after waiting {...} seconds for the user to authenticate". The difference is due to the behavior ofHTTPServer.handle_request(). On 2.7 it raises IOError but we were only expecting the ValueError raised on 3.x.This PR fixes the behavior on 2.7 by handling IOError as well, and updates the test covering this behavior to use an actual instance of the redirect handler rather than a mock.