[Mgmt Compute] Sanitize SAS tokens in recordings#23331
Merged
mccoyp merged 1 commit intoAzure:mainfrom Mar 4, 2022
Merged
Conversation
sima-zhu
approved these changes
Mar 4, 2022
Contributor
sima-zhu
left a comment
sima-zhu
left a comment
There was a problem hiding this comment.
LGTM. PR check passed, so prove to be valid to credscan
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Mar 4, 2022
…into new_metrics_advisor * 'main' of https://github.com/Azure/azure-sdk-for-python: (92 commits) [Mgmt Compute] Sanitize recordings (Azure#23331) [Tables] Release prep (Azure#23297) [Cosmos] move system_key logic to query_iterable (Azure#22893) [Cosmos] added additional warning to default consistency change (Azure#23225) update template (Azure#23333) [Storage] Address comments from API Review for March release (Azure#23294) code and test (Azure#23273) [textanalytics] release prep + fixing docstrings and links (Azure#23315) [Schema Registry] rename request kwargs to request options (Azure#23325) update new app service api version (Azure#23034) [SchemaRegistry] add tests for error codes (Azure#23140) Increment package version after release of azure-core (Azure#23319) Sync eng/common directory with azure-sdk-tools for PR 2824 (Azure#23314) Add python credscan in ci.yml (Azure#23307) [SchemaRegistry] avro api changes (Azure#23259) [KeyVualt KV] Fix cspell errors (Azure#23255) [KeyVault Certs] Fix cspell errors (Azure#23251) [AutoRelease] t2-containerregistry-2022-02-21-89653(Do not merge) (Azure#23155) [KeyVault Keys] Fix cspell errors (Azure#23250) Sync eng/common directory with azure-sdk-tools for PR 2830 (Azure#23267) ...
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some recently checked-in recordings in
azure-mgmt-computecontain SAS tokens for test resources -- this raised CredScan warnings that can be resolved by sanitizing the value ofaccessSASkeys in recording bodies. This adds a sanitizer to do this and updates recordings accordingly.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines