Skip to content

Add Azure Developer Credential#27916

Merged
xiangyan99 merged 23 commits intoAzure:mainfrom
hemarina:add-azd
Jan 19, 2023
Merged

Add Azure Developer Credential#27916
xiangyan99 merged 23 commits intoAzure:mainfrom
hemarina:add-azd

Conversation

@hemarina
Copy link
Copy Markdown
Contributor

@hemarina hemarina commented Dec 13, 2022

Description

  • add azure developer credential and implementation
  • add unit test
  • change readme

WIP:
update test once tenantId is added under GetToken in azd repo

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Azure.Identity label Dec 13, 2022
@hemarina hemarina marked this pull request as ready for review January 11, 2023 00:27
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py Outdated
Comment thread sdk/identity/azure-identity/azure/identity/_credentials/azd_cli.py
@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

@hemarina hemarina requested review from xiangyan99 and removed request for pvaneck and schaabs January 12, 2023 18:38
@hemarina hemarina changed the title WIP: Add Azure Developer Credential Add Azure Developer Credential Jan 12, 2023
Comment thread sdk/identity/azure-identity/README.md Outdated
Copy link
Copy Markdown
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good.

Please fix CI failures.

@hemarina
Copy link
Copy Markdown
Contributor Author

hemarina commented Jan 19, 2023

@xiangyan99 FYI All tests passed except for Run verifytypes. Thanks for the help from @kristapratico and we decided to skip the types for azure-identity until azure-core typing is removed from envirnoment_exclusions.py.
If this looks good, feel free to merge this PR (I don't have access to merge it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants