[Cosmos] Bugfix: async create_container_if_not_exists throwing unexpected keyword argument on read() method#29136
Merged
simorenoh merged 2 commits intoAzure:mainfrom Mar 3, 2023
Conversation
simorenoh
requested review from
annatisch,
bambriz,
kushagraThapar,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
Collaborator
|
API change check API changes are not detected in this pull request. |
bambriz
approved these changes
Mar 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25318.
Bugfix for create_if_not_exists() when passing in kwargs that don't apply to read method. Now we pop the kwargs pre-emptively to calling read() and ensure that the method is not populated with irrelevant options, matching behavior of sync client.