RFC 1123 date format fix#30125
Conversation
This fixes an issue with non english locales making non RFC 1123 Date formats. This fix makes it into a RFC 1123 Date format regardless of the locale.
update changelog to include PR link
|
API change check API changes are not detected in this pull request. |
|
Question, why are we re-inventing the wheel here? Is there no existing native package we can use? I'd think we would want to avoid any manual parsing or creating of day/month abbreviations if we don't exclusively need them. |
Updated to use emails.utils formatdate as it does exactly what the manual implementation would have done.
Changed to use email.utils formatdate. |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simorenoh
left a comment
There was a problem hiding this comment.
LGTM thanks Bryan - seems like we will have to disable the pkdelete test while we update the subscription being used for our pipeline test account. I'll make an issue for that and assign you to it.
Currently pipeplines dont support this feature
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
This fixes an issue with non-English locales making non-RFC 1123 Date formats. This fix makes it into an RFC 1123 Date format regardless of the locale. See Issue 29109
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines