Skip to content

[Identity] Suppress stdin for subprocess-based creds#31534

Merged
pvaneck merged 1 commit intoAzure:mainfrom
pvaneck:identity-cli-stdin-fix
Aug 28, 2023
Merged

[Identity] Suppress stdin for subprocess-based creds#31534
pvaneck merged 1 commit intoAzure:mainfrom
pvaneck:identity-cli-stdin-fix

Conversation

@pvaneck
Copy link
Copy Markdown
Member

@pvaneck pvaneck commented Aug 9, 2023

In some cases, the underyling executable being called hangs waiting for user input. When calling the executables we can ignore stdin.

Closes: #31493

@azure-sdk
Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

In some cases, the underyling executable being called
hangs waiting for user input. When calling the executables
we should just ignore stdin.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck force-pushed the identity-cli-stdin-fix branch from dec6849 to 9e1d5e0 Compare August 28, 2023 18:59
@pvaneck pvaneck requested a review from a team as a code owner August 28, 2023 18:59
@xiangyan99
Copy link
Copy Markdown
Member

Do other languages also need this?

@pvaneck
Copy link
Copy Markdown
Member Author

pvaneck commented Aug 28, 2023

Do other languages also need this?

I am not certain on the stdin behavior in other languages. but I did bring this up to the group a few weeks back. I know an issue about this was already opened in the Java repo.

I can verify and open issues with other languages if the issue is recreatable.

@christothes
Copy link
Copy Markdown
Member

Do other languages also need this?

I am not certain on the stdin behavior in other languages. but I did bring this up to the group a few weeks back. I know an issue about this was already opened in the Java repo.

I can verify and open issues with other languages if the issue is recreatable.

We already have an issue for this in .NET also Azure/azure-sdk-for-net#32993

@pvaneck
Copy link
Copy Markdown
Member Author

pvaneck commented Aug 28, 2023

Checked JS/Go and they don't appear to hang for stdin when auto-upgrade is enabled for az. So I believe each affected language should have issues open regarding this.

@pvaneck pvaneck merged commit e7d72f5 into Azure:main Aug 28, 2023
@pvaneck pvaneck deleted the identity-cli-stdin-fix branch August 28, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azure CLI will *always* cause AzureCliCredential to fail on unupgraded Python/MacOS/Homebrew builds using secret-client.

4 participants