[Identity] Small improvements#31544
Merged
pvaneck merged 3 commits intoAzure:mainfrom Sep 5, 2023
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
- Ensure the `enable_cae` isn't passed in to msal through kwargs There was only one spot where this was the case. - Ensure kwargs are passed through to _get_jwt_assertion_request. - Pop enable_cae for sync pipeline runner. This mirrors the behavior of the async pipeline runner. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
identity-cae-pops
branch
from
6b09316 to
ed892a6
Compare
pvaneck
requested review from
KarishmaGhiya,
ahsonkhan,
billwert,
joshfree,
mpodwysocki and
schaabs
xiangyan99
reviewed
Aug 29, 2023
|
|
||
| def obtain_token_by_jwt_assertion(self, scopes: Iterable[str], assertion: str, **kwargs: Any) -> AccessToken: | ||
| request = self._get_jwt_assertion_request(scopes, assertion) | ||
| request = self._get_jwt_assertion_request(scopes, assertion, **kwargs) |
Member
There was a problem hiding this comment.
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
xiangyan99
reviewed
Aug 30, 2023
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
xiangyan99
approved these changes
Sep 5, 2023
joshfree
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable_caeisn't passed in to msal through kwargs. There was only one spot where this was the case.enable_caefor sync pipeline runner. This mirrors the behavior of the async pipeline runner.