Skip to content

[Identity] Disable loading profiles in powershell #31682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvaneck merged 2 commits into from
Aug 17, 2023
Merged

[Identity] Disable loading profiles in powershell #31682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff24891
[Identity] Disable loading profiles in powershell
pvaneck Aug 16, 2023
e95bb3f
Update changelog
pvaneck Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

### Bugs Fixed

- Ensure `AzurePowershellCredential` calls PowerShell with the `-NoProfile` flag to avoid loading user profiles for more consistent behavior. ([#31682](https://github.com/Azure/azure-sdk-for-python/pull/31682))

### Other Changes

## 1.14.0 (2023-08-08)
Expand Down
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/azure/identity/_credentials/azure_powershell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def get_command_line(scopes: Tuple[str, ...], tenant_id: str) -> List[str]:
script = SCRIPT.format(NO_AZ_ACCOUNT_MODULE, resource, tenant_argument)
encoded_script = base64.b64encode(script.encode("utf-16-le")).decode()

command = "pwsh -NonInteractive -EncodedCommand " + encoded_script
command = "pwsh -NoProfile -NonInteractive -EncodedCommand " + encoded_script
if sys.platform.startswith("win"):
return ["cmd", "/c", command]
return ["/bin/sh", "-c", command]
Expand Down
6 changes: 3 additions & 3 deletions sdk/identity/azure-identity/tests/test_powershell_credential.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_get_token(stderr):
assert Popen.call_count == 1
args, kwargs = Popen.call_args
command = args[0][-1]
assert command.startswith("pwsh -NonInteractive -EncodedCommand ")
assert command.startswith("pwsh -NoProfile -NonInteractive -EncodedCommand ")

encoded_script = command.split()[-1]
decoded_script = base64.b64decode(encoded_script).decode("utf-16-le")
Expand Down Expand Up @@ -267,7 +267,7 @@ def test_multitenant_authentication():
second_token = first_token * 2

def fake_Popen(command, **_):
assert command[-1].startswith("pwsh -NonInteractive -EncodedCommand ")
assert command[-1].startswith("pwsh -NoProfile -NonInteractive -EncodedCommand ")
encoded_script = command[-1].split()[-1]
decoded_script = base64.b64decode(encoded_script).decode("utf-16-le")
match = re.search(r"Get-AzAccessToken -ResourceUrl '(\S+)'(?: -TenantId (\S+))?", decoded_script)
Expand Down Expand Up @@ -297,7 +297,7 @@ def test_multitenant_authentication_not_allowed():
expected_token = "***"

def fake_Popen(command, **_):
assert command[-1].startswith("pwsh -NonInteractive -EncodedCommand ")
assert command[-1].startswith("pwsh -NoProfile -NonInteractive -EncodedCommand ")
encoded_script = command[-1].split()[-1]
decoded_script = base64.b64decode(encoded_script).decode("utf-16-le")
match = re.search(r"Get-AzAccessToken -ResourceUrl '(\S+)'(?: -TenantId (\S+))?", decoded_script)
Expand Down
6 changes: 3 additions & 3 deletions sdk/identity/azure-identity/tests/test_powershell_credential_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ async def test_get_token(stderr):
assert mock_exec.call_count == 1
args, kwargs = mock_exec.call_args
command = args[-1]
assert command.startswith("pwsh -NonInteractive -EncodedCommand ")
assert command.startswith("pwsh -NoProfile -NonInteractive -EncodedCommand ")

encoded_script = command.split()[-1]
decoded_script = base64.b64decode(encoded_script).decode("utf-16-le")
Expand Down Expand Up @@ -265,7 +265,7 @@ async def test_multitenant_authentication():

async def fake_exec(*args, **_):
command = args[2]
assert command.startswith("pwsh -NonInteractive -EncodedCommand ")
assert command.startswith("pwsh -NoProfile -NonInteractive -EncodedCommand ")
encoded_script = command.split()[-1]
decoded_script = base64.b64decode(encoded_script).decode("utf-16-le")
match = re.search(r"Get-AzAccessToken -ResourceUrl '(\S+)'(?: -TenantId (\S+))?", decoded_script)
Expand Down Expand Up @@ -296,7 +296,7 @@ async def test_multitenant_authentication_not_allowed():

async def fake_exec(*args, **_):
command = args[2]
assert command.startswith("pwsh -NonInteractive -EncodedCommand ")
assert command.startswith("pwsh -NoProfile -NonInteractive -EncodedCommand ")
encoded_script = command.split()[-1]
decoded_script = base64.b64decode(encoded_script).decode("utf-16-le")
match = re.search(r"Get-AzAccessToken -ResourceUrl '(\S+)'(?: -TenantId (\S+))?", decoded_script)
Expand Down
⚡