Skip to content

Add ability to configure which logger to collect telemetry for Azure monitor distro #32192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 5 commits into from
Sep 26, 2023
Merged

Add ability to configure which logger to collect telemetry for Azure monitor distro #32192

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
196d255
log
lzchen Sep 22, 2023
a2f7be6
api
lzchen Sep 25, 2023
5681830
feedbackl
lzchen Sep 25, 2023
375f907
def
lzchen Sep 25, 2023
6f0bc0a
Update README.md
lzchen Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ You can use `configure_azure_monitor` to set up instrumentation for your app to
| Parameter | Description | Environment Variable |
|-------------------|----------------------------------------------------|----------------------|
| `connection_string` | The [connection string][connection_string_doc] for your Application Insights resource. The connection string will be automatically populated from the `APPLICATIONINSIGHTS_CONNECTION_STRING` environment variable if not explicitly passed in. | `APPLICATIONINSIGHTS_CONNECTION_STRING` |
| `logger_name` | The name of the [Python logger][python_logger] and all of it's children loggers that you want to collect telemetry for. | `N/A` |
| `logger_name` | The name of the [Python logger][python_logger] to collect telemetry for. | `N/A` |
Comment thread
lzchen marked this conversation as resolved.
Outdated

You can configure further with [OpenTelemetry environment variables][ot_env_vars] such as:
| Environment Variable | Description |
Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def _setup_logging(configurations: Dict[str, ConfigurationValue]):
)
get_logger_provider().add_log_record_processor(log_record_processor)
handler = LoggingHandler(logger_provider=get_logger_provider())
logger_name = configurations[LOGGER_NAME_ARG]
logger_name = configurations.get(LOGGER_NAME_ARG, "")
Comment thread
lzchen marked this conversation as resolved.
Outdated
getLogger(logger_name).addHandler(handler)


Expand Down
⚡