Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
requested review from
bambriz,
kushagraThapar,
simorenoh and
xinlian12
as code owners
annatisch
commented
Jan 10, 2024
xiangyan99
reviewed
Jan 10, 2024
annatisch
commented
Jan 10, 2024
annatisch
commented
Jan 10, 2024
xiangyan99
reviewed
Jan 10, 2024
xiangyan99
reviewed
Jan 10, 2024
xiangyan99
reviewed
Jan 10, 2024
simorenoh
reviewed
Jan 11, 2024
Member
simorenoh
left a comment
simorenoh
left a comment
There was a problem hiding this comment.
Thank you so much Anna, so much of this actually makes our internal methods much more readable for anyone who works on the SDK ❤️ LGTM, just had the one bit on the way we want to evaluate the default for the elapsed_time in the policy 😄
Member
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally getting to mypy-green...